| Summary: | FILEOPEN: SVG: xlink:href in radialGradient/linearGradient doesn't work if referred element hasn't been parsed yet | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | sasha.libreoffice |
| Component: | Draw | Assignee: | Xisco Faulí <xiscofauli> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexpikptz, bfo.bugmail, h3734236, raal, stgohi-lobugs, vsfoote, xiscofauli |
| Priority: | medium | ||
| Version: | 3.3.4 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 88277 | ||
| Attachments: |
test case of svg file importing
reduced document another sample |
||
Confirmed with: LO 3.5.5.3 Build ID: own W7 debug build Windows 7 Professional SP1 64 bit A lots of problems with color gradients (headlights, engine cover, wheels, backlights etc.). Reproducible with LibreOffice 4.2.5 and 4.3.0 on Debian x86_64. On Windows 7 sp1, 64-bit en-US Version: 4.4.0.2 Build ID: a3603970151a6ae2596acd62b70112f4d376b990 Locale: en_US The SVG Insert -> Image filter renders this correctly. The SVG fileOpen filter (Draw) does not. Created attachment 120455 [details] reduced document In the reduced document the radialGradient contains a xlink:href= to #linearGradient4134" which is a linearGradient. The problem is that the linearGradient is defined in the document after the radialGradient in the document so it fails to find it at http://opengrok.libreoffice.org/xref/core/filter/source/svg/svgreader.cxx#222 as the linearGradient hasn't been parsed yet *** Bug 95652 has been marked as a duplicate of this bug. *** Change summary accordingly Created attachment 120581 [details]
another sample
Migrating Whiteboard tags to Keywords: (filter:svgOpen) Reproducible with LO 5.0.3.2, Win 8.1 Xisco Fauli committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6e8a8650d4729965cb694d37592fd418c949a79 tdf#47262 SVG: Parse gradient styles twice if the referred... It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 58351 [details] test case of svg file importing To reproduce this problem: 0. Start LibreOffice 1. File->Open, select file vochito.svg Expected: color gradients in picture are correct Actually: color gradients are grey Reproduced in 3.3.4 and 3.5.0 on Fedora 64 bit