Summary: | EDITING: Queries loose sorting-order when reopening for editing | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Robert Großkopf <robert> |
Component: | Base | Assignee: | Lionel Elie Mamane <lionel> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | lionel, lo_bugs, serval2412 |
Priority: | high | Keywords: | regression |
Version: | 3.5.1 RC1 | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | target:3.5.2 target:3.6.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 37361, 47370 | ||
Attachments: | When reopening the queries for editing in GUI-Mode sorting has gone |
I have reproduced the problem with LO-3.5.1-rc1 on SLED11-SP1-x86_64. Lionel, could you please have a look? It is annoying, so I added it into most annoying bugs. We should fix it soon but it does not cause a real data loss, so it should not block the 3.5.1 release => lowering the severity a bit. dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx, in OSelectionBrowseBox::GetCellText, line 2223, print pEntry->GetOrderDir() in gdb shows it's equal to ORDER_NONE. It seems the problem is in dbaccess/source/ui/querydesign/QueryDesignView.cxx, in GetOrderCriteria function, we don't enter in "if (!pParseRoot->getChild(3)->getChild(4)->isLeaf())", so SetOrderDir is never called, it could explain why pEntry->GetOrderDir() can't retrieve the order. Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=80c235510aeb19d4df6a07be7499e70122313bbf fdo#46843 look for order by clause as fifth child of select_statement Julien, I'd like to again thank you for the very precise code pointer. That's very helpful and allows to very quickly make a fix. Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "libreoffice-3-5": http://cgit.freedesktop.org/libreoffice/core/commit/?id=73a5ef4cb245acb120f02d487ba7c3aeb40f4fad&g=libreoffice-3-5 fdo#46843 look for order by clause as fifth child of select_statement It will be available in LibreOffice 3.5.2. |
Created attachment 57874 [details] When reopening the queries for editing in GUI-Mode sorting has gone When you open both queries of the attachment you see: they are sorted. First by names, second by jobs. When opening for editing in GUI-mode you could see nothing of this sorting. Changing from design-mode to sql-mode shows: the sorting of the queries has gone. If somebody would change any other thing of the query and does not recognise this he saves a query without sorting.