Summary: | Correctly import "center across selection" alignment settings. | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Orion Poplawski <orion> |
Component: | Calc | Assignee: | Kohei Yoshida <kohei> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | regression |
Priority: | medium | ||
Version: | 3.4.3 release | ||
Hardware: | All | ||
OS: | Linux (All) | ||
Whiteboard: | target:3.5 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
test xls document
Screenshot of error message on file save under 3.4.4 and 3.5.0 |
Have not yet tested with earlier 3.4.X. Confirming. Also, at this point we need to shift our focus toward 3.5, so I'll take a look at this for 3.5. Created attachment 54170 [details]
Screenshot of error message on file save under 3.4.4 and 3.5.0
Cells A9+B9, A27+B27, A28+B28 and A29+B29 are merged. This shows up correctly in LO 3.3.4
Under LO 3.4.4 and 3.5.0 (Build ID: bee2841-43e9388-090bcba-d1db994-02ece8a) the merge property is lost and therefore the text in cell A appears to be shifted because it is centered on a single cell where it doesn't fit.
The loss of the merge information is indeed a regression.
Re-merging cells A and B for those lines is properly saved both under 3.4.4 and 3.5.0
Some information is lost (15kB out of 130kB) on Save but it is related to Basic Code (see attached image) so this is probably another bug.
Fixed on libreoffice-3-5 and master. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=561f082041c5ede44d9443e534761a79953aedad It was introduced due to DECLARE_LIST removal, which unfortunately changed the logic around this code. Setting the logic back prior to the DECLARE_LIST removal fixes it. Pushed to 3-4 with my sign-off http://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4&id=53757e9d714d6b3cde83d5b4c390e9e2739bfb2c |
Created attachment 53585 [details] test xls document With LibreOffice 3.3.3.1/3.3.4.1 the attached file is opened properly. With 3.4.3.2/3.4.4.1 it is not. There are three main problems: - Account in A9 is shifted to the left off page - Month Total in A27 is shifted to the left off page - The Signed: label in A29 is wrapped to two lines and truncated on top When saved the incorrect formatting is preserved such that Excel will have the incorrect formatting.