Bug 42783

Summary:	get rid of CPU define/build system variable
Product:	LibreOffice	Reporter:	Björn Michaelsen <bjoern.michaelsen>
Component:	LibreOffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dtardon, robinson.libreoffice
Priority:	medium	Keywords:	difficultyBeginner, easyHack, skillScript, topicCleanup
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:	target:3.6.0
Crash report or crash signature:		Regression By:
Attachments:	First try at EasyHack

Description Björn Michaelsen 2011-11-10 04:11:21 UTC

The variables CPU and CPUNAME contain exact the same information and the existence of both leads can just lead to needless errors. CPU is limited to one character leading to obnoxious names like "R" for arm or "6" for Motorola 68000, thus is it the obvious candidate to go an be replaced by CPUNAME.

Comment 1 Björn Michaelsen 2011-11-10 04:12:04 UTC

Skills: code reading, some building

Comment 2 Thomas Collerton 2012-02-25 03:15:58 UTC

This is my first try, though i had to skip the SPARC64 bits, being CPU=U not defined in configure.in

Comment 3 Thomas Collerton 2012-02-25 03:16:37 UTC

Created attachment 57629 [details]
First try at EasyHack

Comment 4 Michael Meeks 2012-05-09 02:27:51 UTC

Norbert commented on the list:

> The patch does not remove CPU, just replace some of it's use with CPUNAME.
> among other annoying part is the fact that prebuilt moziila filename
> are based on CPU not CPUNAME
> so any such patch need to be synch with a rename of these files... and
> somehow a rename of the existing file in moz/zipped if there are
> there...

prolly best to continue discussion there; thanks !

Comment 5 Not Assigned 2012-05-09 07:35:36 UTC

Thomas Collerton committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9520dbf59f6bd6c86791954e082488556a610adc

EasyHack fdo#42783: get rid of CPU define/build system variable

Comment 6 Robinson Tryon (qubit) 2015-12-16 00:19:56 UTC

Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillScript TopicCleanup )
[NinjaEdit]