Summary: | simplify lcl_GetRelativePos | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Caolán McNamara <caolan.mcnamara> |
Component: | Calc | Assignee: | Kohei Yoshida <kohei> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Attachments: | like so |
Yup, the patch makes sense, and it's a lot simpler. I've committed it locally, and as soon as kendy is done merging the integration/dev300_m101 branch onto master I'll push. Merging is done. Pushed to master. |
Created attachment 44568 [details] like so In sc/source/ui/unoobj/shapeuno.cxx we have a ScRange aRange = ... where aRange is then unused, it seems the entire line doesn't do anything, which leaves a symmetrical expression that can be simplified a bit, as attached.