| Summary: | 1bit PNGs rendered in black and white | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | bugzilla33 |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | CLOSED FIXED | ||
| Severity: | major | CC: | caolan.mcnamara, thb |
| Priority: | medium | ||
| Version: | 3.3.0 release | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=80160 | ||
| Whiteboard: | target:4.4.0 target:4.3.0.2 target:4.2.6 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
testcase
document proposed fix having a stab at the windows one too |
||
Created attachment 42444 [details]
document
confirmed :-/ strange when you insert a picture ( same 1 bit per pixel example ) works fine. Additionally the embedded image ( for the backgraphic ) is correct so really this is some strange setting in the writer code I think. I will try to have a look at thing Testing OOo 3.3 and LibO 3.3 on Fedora 13. The test image gives results exactly reversed from that shown in the document.png image: the Format > Page > Background preview panel shows the image having black pixels, but the document background shows red pixels. An exported pdf shows red as well. This is some cockup where 0% transparency is != no transparency or something of that nature. nah, tweaking transparency just promotes it to a different bits per pixel of course. vcl drawing appears to simply assume white/black for one bit depths Created attachment 44850 [details]
proposed fix
cmc->thb: How about the attached, does that look sane to you ? ah crap, bug says windows, so while this would fix it for me on linux more work required there I guess. Created attachment 44851 [details]
having a stab at the windows one too
Yeah, that clearly looks right - and aligns x11/win32 behaviour with svp and aqua plug. confirmed builds under windows Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=be9d65bb5f5a83c19eec02a037b8f808de70ecb8 Related: fdo#33455 retain color on scaling of 1 bit depth pngs The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=db298f22a04e409a555d7c3ccec4c1dae91a6e1b&h=libreoffice-4-3 Related: fdo#33455 retain color on scaling of 1 bit depth pngs It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a519b6203eb4ea9be61d8e5c3da7fd51e4d71419&h=libreoffice-4-2 Related: fdo#33455 retain color on scaling of 1 bit depth pngs It will be available in LibreOffice 4.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 42442 [details] testcase 1-bit per pixel PNGs are not decoded correctly. See attachments.