Bug 160701

Summary: OpenPGP warning when encrypting with an untrusted public key: rename from "Error" to "Warning"
Product: LibreOffice Reporter: steve <lo>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: trivial CC: guibomacdev, kolAflash, mentoring
Priority: low Keywords: difficultyBeginner, easyHack, skillCpp
Version: 24.8.0.0 alpha0+ Master   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=160184
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 158839    
Attachments: Screenshot info message about encrypting with an untrusted public OpenPGP key

Description steve 2024-04-16 22:24:10 UTC 
Description:
Gladly https://bugs.documentfoundation.org/show_bug.cgi?id=160184 got resolved and OpenPGP encryption with untrusted keys is now possible.

A warning is shown beforehand. Currently that warning is labled "Error" which I find misleading and confusing. An error suggests that something is wrong with the software. That is not the case here.

Would it be possible to re-label the dialog as "Warning" which better suits the nature of the context in this case?

Steps to Reproduce:
1. open writer and write test
2. save document
3. in save dialog tick option "Encrypt with GPG key" and click "save" button
4. make sure you have an untrusted public OpenPGP key in your keyring and select that from the "Select Certificate" dialog

Actual Results:
Dialog with title "Error" is shown.

Expected Results:
Dialog title could be "Warning" instead.

There is a side-problem that the dialog gives no advice how to resolve the situation the warning is about, i.e. trust a key. But that is a complex problem and probably out of scope for LibreOffice at that point.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 38ed8100872913c64941927bba665e4bd1a44c12
CPU threads: 12; OS: macOS 14.4.1; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 steve 2024-04-16 22:24:25 UTC 
Created attachment 193716 [details]
Screenshot info message about encrypting with an untrusted public OpenPGP key
Comment 2 kolAflash 2024-05-02 16:31:24 UTC 
Confirming the issue.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7e553a56c6a5aa7f4b1f01df52ed9607d3397cfc
CPU threads: 16; OS: Linux 6.1; UI render: default; VCL: x11
Locale: en-US (C); UI: en-US
Calc: threaded

The dialog window has been added in this two commits in the mentioned bug 160184.
https://git.libreoffice.org/core/+/6a049e417b029f3733fcee05f99a3e8875aefdb8%5E%21
https://git.libreoffice.org/core/+/c4023d3ec604abfff38be2053e2989c7ec2ba8c1%5E%21
Hint: Look there to find out what needs to be changed.

Marking this as easyHack.