Bug 159091

Summary: UI: The function of the Automatic recovery dialog was interrupted dialog is obscure
Product: LibreOffice Reporter: Telesto <telesto>
Component: DocumentationAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: heiko.tietze, olivier.hallot
Priority: medium Keywords: needsDevAdvice
Version: 24.8.0.0 alpha0+   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 77999, 112970    
Attachments: Screenshot

Description Telesto 2024-01-09 15:30:56 UTC 
Description:
UI: The function of the Automatic recovery dialog was interrupted dialog is obscure

Steps to Reproduce:
1. Open the attached file (password: ABC)(or create a passworded file yourself)
2. Tools -> Options -> Load/Save -> General -> Set autosave to 1 minute (and press OK)
3. Make some change.. and wait 60 seconds
4. Force quite LibreOffice from the task manager
5. Click recover selected
5. In Enter password dialog -> press Cancel (2x)-> The automatic recovery process was interrupted dialog appears 

Actual Results:
The automatic recovery process was interrupted dialog appears 

Expected Results:
1) What happens if the "Save to" document location being the same as the original file before crash? Will it be overwritten?
2. What is actually stored? It doesn't appear to include the auto-save information (so what supposed to be saved?). What's the use-case?
3) What's the reasoning behind the default document path? Original location seems more fitting?


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: a9ad36ae46ff76c0d59b0d170314fdd3a9ee5d35
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: threaded
Comment 1 Telesto 2024-01-09 18:06:09 UTC 
Created attachment 191828 [details]
Screenshot
Comment 2 Heiko Tietze 2024-01-22 10:23:23 UTC 
(In reply to Telesto from comment #0)
> 1) What happens if the "Save to" document location being the same as the
> original file before crash? Will it be overwritten?
Why don't you test it? I guess the system show a confirmation dialog whether you want to overwrite the file.

> 2. What is actually stored?
> 3) What's the reasoning behind the default document path? Original location
> seems more fitting?

=> needsDevAdvice

(Ultimately a question for documentation, IMO)
Comment 3 Telesto 2024-01-22 15:30:12 UTC 
(In reply to Heiko Tietze from comment #2)
> (In reply to Telesto from comment #0)
> > 1) What happens if the "Save to" document location being the same as the
> > original file before crash? Will it be overwritten?
> Why don't you test it? I guess the system show a confirmation dialog whether
> you want to overwrite the file.

I did at some point. It doesn't show a conformation; but it actually adds a copy with unique number
Comment 4 Telesto 2024-01-22 15:40:18 UTC 
(In reply to Heiko Tietze from comment #2)
> > 2. What is actually stored?
> > 3) What's the reasoning behind the default document path? Original location
> > seems more fitting?
> 
> => needsDevAdvice
> 
> (Ultimately a question for documentation, IMO)

Some additional questions/comments 
A) I can more or less understand to save a copy if the recovery got interrupted by external cause. However I always get the dialog if I discard the automatic recovery. So I'm actually discarding recovery; and next I get message Automatic Recovery being interrupted: duh, I did that on purpose

B)The dialog somewhat suggests (at least to me) that the copy would include the recovery information, based on cases like:
(a) the recovery got interrupted by external cause
(b) in case of pressing cancel for password dialog. 

However it doesn't. It simply a copy of some version of the document (no idea which one, actually).

C) Is this not some kind of security risk. If a file at network drive being edited. LibreOffice crashes. Next the file being stored locally?