Bug 158778

Summary: duplicate libcrypto-3.dll file in main MSI archive
Product: LibreOffice Reporter: Jérôme <jerome.bouat>
Component: InstallationAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: stephane.guillou
Priority: medium Keywords: needsDevAdvice
Version: 24.8.0.0 alpha0+   
Hardware: All   
OS: Windows (All)   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 97991    

Description Jérôme 2023-12-19 13:29:32 UTC
In the daily build, the "program" directory contains the below duplicate files reported by fdupes :
LibreOfficeDev 24:./program/libcrypto-3.dll
LibreOfficeDev 24:./program/python-core-3.8.18/lib/libcrypto-3.dll

This duplicate file uses 5 MB.
Comment 1 Jérôme 2023-12-19 13:32:47 UTC
The below 760 kB file is also a duplicate :
LibreOfficeDev 24:./program/libssl-3.dll
LibreOfficeDev 24:./program/python-core-3.8.18/lib/libssl-3.dll
Comment 2 Julien Nabet 2023-12-19 13:38:36 UTC
Related to https://cgit.freedesktop.org/libreoffice/core/commit/?id=b4dfba947768834ffecc09056992019878711c8b
python3: update to 3.8.4
which indicates:
"Then there are the changes introduced in "PEP 587 -- Python
Initialization Configuration", which appearingly have modified the
DLL search path behaviour on Windows, so the OpenSLL DLLs aren't
found anymore in the program directory. As a workaround, the
OpenSLL and libffi DLLs are now (also) installed into the Python
lib dir on Windows."
Comment 3 Jérôme 2023-12-19 15:29:17 UTC
Could we use links (ln -s) for libraries as in Linux ?
Comment 4 Jérôme 2023-12-23 16:06:41 UTC
Symbolic links exist in Windows also with relative path :
https://learn.microsoft.com/en-gb/windows/win32/fileio/creating-symbolic-links
Comment 5 Stéphane Guillou (stragu) 2024-01-02 16:26:46 UTC
Makes sense to find a way to reuse the same file instead of duplicating it.