Bug 158692

Summary: The data could not be loaded completely because the maximum number of rows per sheet was exceeded.
Product: LibreOffice Reporter: Jonny Grant <jg>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: enhancement CC: miguelangelrv
Priority: medium    
Version: 7.6.4.1 release   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: Current behavor

Description Jonny Grant 2023-12-13 23:05:30 UTC
Created attachment 191418 [details]
Current behavor

Could this dialog be updated to show what the limit is?

Looks like the limit is 1,048,576 rows.
Comment 1 m_a_riosv 2023-12-13 23:29:00 UTC
To me, this is a request for enhancement.

With Menu/Tools/Options/LibreOffice/Advanced/Experimental features enable.
Menu/Tools/Options/LibreOffice Calc/Default/Enable very large spreadsheet the limit is 16 million of rows.
Comment 2 ady 2023-12-13 23:52:51 UTC
In addition to enabling (or not) "very large spreadsheets", users could simply:

1. Open a new empty Calc worksheet.
2. [CTRL]+[DownArrow]. The Row Header shows the maximum number of rows.
3. (Optional) Type-in the formula:
=ROW()
and press [ENTER].

Now the maximum number of rows is shown on the cell.
Comment 3 Jonny Grant 2023-12-14 11:19:14 UTC
Thank you for the replies.

Yes, it's the SCWARN_IMPORT_ROW_OVERFLOW message I'm proposing to update.
core/sc/inc/scerrors.hrc

Just needs to format pDoc->MaxRow() as a string and add to the message.

Had a quick look, seems most likely:
core/sc/source/ui/docshell/docsh.cxx

Less likely:
core/sc/source/filter/xml/xmlcelli.cxx

Any code/patch proposal appreciated!
Comment 4 ady 2023-12-14 13:16:24 UTC
FWIW, the max number of rows is (mostly) a fixed value, depending on version and the experimental setting. The max value has changed (only) 3 or 4 times in more than 3 decades. It is not something that will be changing frequently (or at all).

Once the user knows the max values (as in comment 2), they will stay that way for a very long time; it is unlikely that the values will change in the next several years (if ever). If this info were to be introduced in some dialogue, some other user might be tempted to request to add some more info such as the difference between the max value vs. the value required for the attempted action that triggered the dialogue in the first place.
Comment 5 Jonny Grant 2023-12-14 14:43:01 UTC
(In reply to ady from comment #4)
> FWIW, the max number of rows is (mostly) a fixed value, depending on version
> and the experimental setting. The max value has changed (only) 3 or 4 times
> in more than 3 decades. It is not something that will be changing frequently
> (or at all).
> 
> Once the user knows the max values (as in comment 2), they will stay that
> way for a very long time; it is unlikely that the values will change in the
> next several years (if ever). If this info were to be introduced in some
> dialogue, some other user might be tempted to request to add some more info
> such as the difference between the max value vs. the value required for the
> attempted action that triggered the dialogue in the first place.

I think this is getting off message. Anyone can file another PR Enhancement, which would be considered on it's merit, separately from this.

I've made the case for describing limits in the error msgbox. I've directed to the source code file. Are you a programmer on the project? Could you or someone else review.