Summary: | FILEOPEN RTF: break splits paragraph across two pages | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Justin L <jluth> |
Component: | Writer | Assignee: | Justin L <jluth> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jluth, michael.stahl |
Priority: | medium | Keywords: | bibisected, bisected, filter:rtf |
Version: | 7.6.4.1 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=158058 | ||
Whiteboard: | target:24.8.0 target:24.2.0.0.beta2 target:7.6.5 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 113340 |
Description
Justin L
2023-12-07 18:59:57 UTC
confirmed with bibisect 24.2 that is was commit 15f54c82d136e6fee3a65494f3b5271857b5d6b8 Author: Michael Stahlon Wed Nov 15 19:41:49 2023 +0100 writerfilter: remove DomainMapper::text() handling of paragraph break Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159485 Interestingly, this is fixed by the framePr-related https://gerrit.libreoffice.org/c/core/+/160655, even though it isn't broken by the framePr change to sal_utext. Reconfirmed by the bisected commit is to blame by clean compiling. It is the change to lcl_endSectionGroup that triggers the problem, since it is exposed to a lot more "code" than just finishParagraph. bRemove is excessively triggered..., and forcing it to false also fixes the problem. Interesting test: change the charRun "1" into "xyz" and only the "z" will get pulled to the second page. In the "good" case, we never run into the "lcl_endSectionGroup" dummy para code. I think this is ultimately tied back to the framePr thing, which FORCES m_bNeedPar to false. So, instead of ending the \page with a dummy \par, we just jump into the header/footer import and end up at the \sect without ever calling \par. For this particular document, I don't expect bRemove has come into play, although I'm sure it will in many other cases..., related to IsInHeaderFooter. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/798649ec30b536614048aa457fb9c8d4dce30b31 tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/465cc1bbbe86b2affc112c6be79c7c0e9ea885e6 tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame It will be available in 24.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/ee4a371e7cd6029978260b7692fe5b5db00dce8b tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |