| Summary: | The arrowhead control in the sidebar line section is difficult to notice | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Eyal Rozenberg <eyalroz1> |
| Component: | Impress | Assignee: | Akshay Warrier <aksmen121> |
| Status: | ASSIGNED --- | ||
| Severity: | minor | CC: | aksmen121, aron.budea, heiko.tietze, mentoring |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicUI |
| Version: | 7.6.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=160208 | ||
| Whiteboard: | target:24.8.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 65138, 112485 | ||
| Attachments: | Screenshot | ||
|
Description
Eyal Rozenberg
2023-10-21 20:00:58 UTC
Created attachment 190380 [details]
Screenshot
The sidebar must not replicate all UI elements from the dialogs. Adding a label, showing the current arrowheads, and splitting the input in start/end clutters the UI even more. My take, if the unlabeled item is so hard to understand, is to remove it from the sidebar.
(In reply to Heiko Tietze from comment #1) > The sidebar must not replicate all UI elements from the dialogs. I suppose that's a valid design choice, but - it's unreasonable to have Corner Style and Cap Style, but not start and end arrow choice - which are much much more frequently used. Also, expanding the button into a preview still fits into the existing "row", if you wanted to skimp on real-estate. (In reply to Eyal Rozenberg from comment #2) > I suppose that's a valid design choice, but - it's unreasonable to have > Corner Style and Cap Style... Remove it all (the UI is way too busy). (In reply to Heiko Tietze from comment #3) > Remove it all (the UI is way too busy). I... am ok with the current level of business, but this is not a strong opinion. Just saying that at the level we have now, the button is insufficient. We discussed the topic in the design meeting. First step could be to remove the cap/corner style controls and move the arrow head into an extra line with a label. In a follow-up patch we should split the arrow head control into beginning/end controls. Code pointer: svx/uiconfig/ui/sidebarline.ui (remove cornerlabel, edgestyle, caplabel, linecapstyle, add a label for arrow head and move the control there) svx/source/sidebar/line/LinePropertyPanelBase.cxx (remove all mxFTEdgeStyle, mxLBEdgeStyle, and ChangeEdgeStyleHdl and the same for the cap style; don't forget the header file) I was looking a bit into this issue and it looks like the line properties ui is shared with chart2's line properties as well, so removing the cap/corner style controls from the ui file would also reflect in the chart's sidebar as well. Is that desirable? The line cap style is hidden for chart lines. And I see no issue to have a consistent UI if there was a cap style. The arrowhead control is hidden but corner and cap styles are present for chart. But either way, if you say having consistent UI is fine, then we should remove them from there as well. AkshayWarrier committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8cd4cd31e9cffb593ccfba765fa28c2494a2d6f7 tdf#157882 svx: Remove cap/corner styles and move arrowhead control to new row It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |