Summary: | Crash on clicking Reset when modifying Background presentation style (gtk3) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | Impress | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | ashraf2033, caolan.mcnamara, serval2412 |
Priority: | high | Keywords: | bibisected, bisected, haveBacktrace, regression |
Version: | 6.2.0.3 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=154493 | ||
Whiteboard: | target:24.2.0 target:7.6.3 target:7.5.8 | ||
Crash report or crash signature: | ["SfxTabDialogController::LinkStubResetHdl(void*, weld::Button&)","libmergedlo.so","SfxTabDialogController::ResetHdl"] | Regression By: | Caolán McNamara |
Bug Depends on: | |||
Bug Blocks: | 100373, 103182, 133092 | ||
Attachments: | gdb backtrace with 24.2 alpha0+ debug build on Ubuntu 20.04 |
Description
Stéphane Guillou (stragu)
2023-09-29 16:19:42 UTC
Ha turns out it had been reported before in bug 134735 but closed as "not our bug", thought to be an issue with Manjaro's build. *** Bug 134735 has been marked as a duplicate of this bug. *** On pc Debian x86-64 with master sources updated today + gtk3 rendering, I don't reproduce this. Now perhaps it could help (at least distribs like Manjaro) to have a backtrace? (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU/Linux:_How_to_get_a_backtrace) Created attachment 189899 [details] gdb backtrace with 24.2 alpha0+ debug build on Ubuntu 20.04 Was updating my debug build and then forgot to come back to this. With: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 655045d018937b1323f4d576214a50d29e15433d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded ... it crashes as soon as the dialog is opened, with: soffice.bin: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/vcl/unx/gtk3/gtkinst.cxx:8916: int {anonymous}::GtkInstanceNotebook::remove_page(GtkNotebook*, std::u16string_view): Assertion `nPageNumber != -1 && "asked to remove page that doesn't exist"' failed. Backtrace attached. from the backtrace I can see that it comes from sd/source/ui/dlg/prltempl.cxx SdPresLayoutTemplateDlg::SdPresLayoutTemplateDlg and I see if( !SvtCJKOptions::IsAsianTypographyEnabled() ) RemoveTabPage( "RID_SVXPAGE_PARA_ASIAN" ); if (bBackground) { ... RemoveTabPage( "RID_SVXPAGE_PARA_ASIAN" ); ... } so to reproduce this, turn "off" tools, options, language/settings, languages, asian and then follow the steps in comment #1 Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9150c8c09645be12849cdb5aad484ee344b7b313 Resolves: tdf#157515 only remove RID_SVXPAGE_PARA_ASIAN once It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. done in trunk, backports to 7-6 and 7-5 in gerrit (In reply to Caolán McNamara from comment #5) > [...] > so to reproduce this, turn "off" tools, options, language/settings, > languages, asian and then follow the steps in comment #1 Thanks for pointing that out, Caolán! And thanks for the quick fix. For good measure: bibisected to 0e19bb2583717a0284e95f47b1094a5849dfeeaf. Will verify in the next daily build. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/63a93a388e191ef002abb746e8ac06f5a1592f6d Resolves: tdf#157515 only remove RID_SVXPAGE_PARA_ASIAN once It will be available in 7.6.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/d42f178418a255ebba902b9bdea63effe2fd2b70 Resolves: tdf#157515 only remove RID_SVXPAGE_PARA_ASIAN once It will be available in 7.5.8. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 05a1217921b7be283c6750a35b90e4feda6e993e CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Thanks Caolán! |