Bug 156591

Summary: A11Y sidebar: not fixable warning about "Style has no language set."
Product: LibreOffice Reporter: Gabor Kelemen (allotropia) <kelemeng>
Component: WriterAssignee: Balázs Varga (allotropia) <balazs.varga991>
Status: VERIFIED FIXED    
Severity: normal CC: buzea.bogdan
Priority: medium    
Version: 7.6.0.0 alpha0+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=156594
https://bugs.documentfoundation.org/show_bug.cgi?id=156614
https://bugs.documentfoundation.org/show_bug.cgi?id=156615
https://bugs.documentfoundation.org/show_bug.cgi?id=156619
https://bugs.documentfoundation.org/show_bug.cgi?id=156620
Whiteboard: target:24.2.0 target:7.6.2
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 154929    
Attachments: Example file from Writer with several a11y warnings
Screenshot of the issues in the document

Description Gabor Kelemen (allotropia) 2023-08-03 10:16:58 UTC
Created attachment 188740 [details]
Example file from Writer with several a11y warnings

Attached example file contains a style where the language was set to None.
The accessibility sidebar gives a warning about this, but no Fix button to solve the issue.

1. Open attached file
2. Open the Accessibility sidebar
3. Observe the warning "Style “NoLanguage” has no language set."
-> Should have a Fix button to open the NoLanguage style properties dialog

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: eff5a3fe98ca5d1d28c4f5386c4af8a3be8f5703
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2023-08-03 10:17:20 UTC
Created attachment 188741 [details]
Screenshot of the issues in the document
Comment 2 Commit Notification 2023-08-16 15:04:49 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b4cbf44e8d5072e79b62e6b4e3b1c2480e4a34f3

tdf#156591 - A11Y - add fix button for "Style has no language set."

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 BogdanB 2023-08-16 16:14:43 UTC
Working well. Opening the right window.

Verified with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b4cbf44e8d5072e79b62e6b4e3b1c2480e4a34f3
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 Commit Notification 2023-08-30 12:59:23 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/444640a02ee3cfef92a5061c6934c4e0a0a1eaa6

tdf#156591 - A11Y - add fix button for "Style has no language set."

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.