Summary: | Width and Height fields of the Compress dialog don't keep aspect ratio, reset to default value (GTK3) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | caolan.mcnamara |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 6.1.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=122348 | ||
Whiteboard: | target:24.2.0 target:7.6.1 target:7.5.6 | ||
Crash report or crash signature: | Regression By: | Caolán McNamara | |
Bug Depends on: | |||
Bug Blocks: | 103182, 117085 |
Description
Stéphane Guillou (stragu)
2023-07-21 09:58:02 UTC
We're listening to Entry::changed here, but querying the value, and the value doesn't change when the content changes, only after the spinbutton updates which is typically on losing focus so the old value is what is returned. What we do everywhere else is listen to SpinButton::value_changed, so I'll make that change here which should make this work consistently with everything else. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6a51ab527b56ddc2bf6ec6ccbfbf2bc608244355 Resolves: tdf#156411 listen to "value-changed" not "changed" It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/6057cc1df797b980f3d1d917befcb3256f3a9fb6 Resolves: tdf#156411 listen to "value-changed" not "changed" It will be available in 7.6.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/254be6a8192ef5c8a00cc75fb216ff535605325f Resolves: tdf#156411 listen to "value-changed" not "changed" It will be available in 7.5.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thank you, Caolán! Fix verified in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 42364fbfafaa95773c073cc080142b64ec1786fb CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded |