Summary: | border error when docx floating table breaks to two pages because of caption above | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, vmiklos |
Priority: | medium | ||
Version: | 24.2.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=157911 | ||
Whiteboard: | target:24.2.0 target:7.6.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 107701, 139532 | ||
Attachments: |
floating table on one page
Split floating table in Word: top and bottom borders are rendered. Split floating table in Writer: top and bottom borders are rendered. Split floating table in Writer (2 additional paragraphs): bottom border is not rendered. Sample document that reproduces the bad border problem on load. comparison office.com vs LO 24.2 alpha0+ Word 2021 desktop rendering |
Description
Regina Henschel
2023-07-18 11:53:59 UTC
See bug 156349 for the general question if we want captions for floating tables in the first place. But then we can put that aside, you can of course create a multi-page floating table in a different way as well, for example go to the end of the B1 cell and press enter. This is definitely a document model we want to handle for rendering and saving. Writer currently draws a full border around the tables on both pages, and this matches Word. I think it would be wise to keep the compatibility and not introduce a new, own way. Now that's more interesting to me that Writer sometimes does omit the rendering of the border. If I press one more enter in B1, then the bottom border on page 1 is missing. I would consider *that* a bug, in case in other cases both the top and bottom border is rendered. Will attach screenshots. Created attachment 188437 [details]
Split floating table in Word: top and bottom borders are rendered.
Created attachment 188438 [details]
Split floating table in Writer: top and bottom borders are rendered.
Created attachment 188439 [details]
Split floating table in Writer (2 additional paragraphs): bottom border is not rendered.
I didn't reproduce the bug successfully. After I inserted the caption, the table moved down slightly. It was a little bit out of the border of the first page but still on the first page. It didn't go to the second page. Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Created attachment 188736 [details]
Sample document that reproduces the bad border problem on load.
I attach a slightly changed document that shows the border problem on load. The page 1 part of the table has no bottom border in Writer, but the page 2 part of the table has a top border, which is inconsistent.
Word has both a bottom and a top border in this case.
Created attachment 188748 [details] comparison office.com vs LO 24.2 alpha0+ Confirmed with recent master build: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: eef0c5d4d45ba35acfb6d8f7551fe565ca4badaa CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Created attachment 188760 [details]
Word 2021 desktop rendering
Argh, once again office.com and desktop Word rendering differs... I assume at least as first cut desktop LO should be compatible with desktop Word, i.e. what's wanted is borders around both tables.
This would be also compatible with other existing Writer use-cases, e.g. how Writer handles table borders when two linked text frame splits a table.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/53798fef2cc0b5b0b9706081a4af5ceca964a41b Related: tdf#156351 sw floattable: fix missing top border in follow table It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. This just fixes the related top border problem in the second table, the bottom border needs more work in the first table. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/08aea5526c75ff4c5385e960bd940f10ffa19cd5 tdf#156351 sw floattable: fix missing bottom border in master table It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The border looks OK now, I think (the first commit has a test file, you can also manually compare how Word and Writer renders it). Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/99a817c3f41a115e53a95ada33f0611b2572725b Related: tdf#156351 sw floattable: fix missing top border in follow table It will be available in 7.6.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/e7c02ea29d92bed2d713b9a3180bfb1674add908 tdf#156351 sw floattable: fix missing bottom border in master table It will be available in 7.6.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |