Bug 156193

Summary:	Harmonise sticky shape inserting behaviour between Drawing toolbar and Shapes sidebar deck
Product:	LibreOffice	Reporter:	Eyal Rozenberg <eyalroz1>
Component:	Impress	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	enhancement	CC:	heiko.tietze, rb.henschel, stephane.guillou, vsfoote
Priority:	medium
Version:	6.1.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=87643
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103459, 108741

Description Eyal Rozenberg 2023-07-07 14:14:33 UTC

When one clicks a shape in the Shapes deck of the sidebar, and draws a bounding rectangle for the shape - in some cases, the active tool goes back to something other than drawing that shape; and in some cases, the shape remains the active tool, and drawing a rectangle or just clicking somewhere inserts another instance of the shape.

There are two issues here:

1. It is difficult for the user to predict when either of the cases will occur with a press on a shape.
2. The visual indication in the sidebar - a (double) frame around the shape - does not seem to distinguish between these two states.

I believe this should merits UI designer attention and thought.

Among other ideas, perhaps we should default to single-instantiation-always upon the first click on the shape, and only enter "repeat insertion mode" on a double click or second click? Similarly to how the Android's on-screen keyboard's shift key behaves w.r.t. entering uppercase letters?

Comment 1 Regina Henschel 2023-07-08 13:14:01 UTC

Draw and Impress have the simple rule for the drawing toolbar: Single-click on the icon draws one object and double-click on the icon goes in sticky-mode of that icon to draw several objects. Clicking on a different icon turns off sticky-mode. Of cause Esc-key and Select-icon turn off sticky-mode as well.

The sidebar behaves different. If you have once used an icon in sticky-mode, than it keeps that mode for other icons of the same category. It goes in normal mode when you use an icon from a different category. The sidebar has no indication whether it is in sticky mode or not.

The behavior of the sidebar is inconsistent, not obvious and different from the drawing toolbar. I agree that the behavior of the sidebar has to be changed.

I think, the sidebar should behave the same as the drawing toolbar in regard to double-click and sticky-mode.

As indication that it is not in sticky-mode, the selection frame around the icon should be removed after the shape is drawn.

Comment 2 Eyal Rozenberg 2023-07-08 17:01:06 UTC

(In reply to Regina Henschel from comment #1)
> The sidebar has no indication whether it is in sticky mode or not.

This is the crux of this bug.

> As indication that it is not in sticky-mode, the selection frame around the
> icon should be removed after the shape is drawn.

That would be helpful (but I'm not against some other option for how to indicate stickiness).

> The behavior of the sidebar is inconsistent, not obvious and different from
> the drawing toolbar. I agree that the behavior of the sidebar has to be
> changed.

Should we split this bug in two, one for the visual indication and one for the behavior itself?

Comment 3 V Stuart Foote 2023-07-08 18:58:16 UTC

(In reply to Regina Henschel from comment #1)
> ...
> The behavior of the sidebar is inconsistent, not obvious and different from
> the drawing toolbar. I agree that the behavior of the sidebar has to be
> changed.
> 
> I think, the sidebar should behave the same as the drawing toolbar in regard
> to double-click and sticky-mode.
> 
> As indication that it is not in sticky-mode, the selection frame around the
> icon should be removed after the shape is drawn.

+1, for adjustment to SB content panel widget handling in effort to match TB widgets; here specifically to insertion modes for shapes and other draw objects.

Comment 4 Stéphane Guillou (stragu) 2023-07-09 17:00:34 UTC

Regina and Stuart agree, same for me, let's mark as a New enhancement request.

Was already the case when the deck was added in 6.1:

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group threaded

(Related issue in my opinion is that the single-click in Writer's Standard toolbar is sticky.)

Comment 5 Heiko Tietze 2023-07-10 08:20:23 UTC

(In reply to Regina Henschel from comment #1)
> I think, the sidebar should behave the same as the drawing toolbar in regard
> to double-click and sticky-mode.
> 
> As indication that it is not in sticky-mode, the selection frame around the
> icon should be removed after the shape is drawn.

+1