| Summary: | Regression: dashed lines become solid when breaking imported SVG / exporting to SVG | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Roland Baudin <roland65> |
| Component: | Draw | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | ||
| Severity: | normal | CC: | adonis192, andygp999, aron.budea, divirtual, hossein, l.lunak, stephane.guillou, telesto, vmiklos, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, filter:svg, regression |
| Version: | 7.1.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=136957 https://bugs.documentfoundation.org/show_bug.cgi?id=151326 https://bugs.documentfoundation.org/show_bug.cgi?id=152997 https://bugs.documentfoundation.org/show_bug.cgi?id=86206 https://bugs.documentfoundation.org/show_bug.cgi?id=156160 |
||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | Luboš Luňák | |
| Bug Depends on: | |||
| Bug Blocks: | 88278, 111450, 156767 | ||
| Attachments: |
SVG image with dashed lines
New example document for Impress SVG simple image |
||
|
Description
Roland Baudin
2023-05-09 10:03:34 UTC
Created attachment 187163 [details]
SVG image with dashed lines
Confirmed with in recent master: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b10417eb1e5a4a6959e7fc1cdd9819e5b09d39a4 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Original SVG shows 4 dashed segments, as shown in Firefox, GNOME Image Viewer and Inkscape. Inkscape shows a custom dashed line styles using 7.5002 / 7.5002 pattern. LO's imported SVG looks correct, until using Break, which converts to solid lines. Bibisected with linux-64-7.1 repo to first bad commit a8c7987e61bdb4f12f3a84f5df92c1315525f6f7 which points to core commit b71d9a6d15cfb8a50afdea5ac064f40d84c561f8 which is a cherrypick of: commit b71d9a6d15cfb8a50afdea5ac064f40d84c561f8 author Luboš Luňák <l.lunak@collabora.com> Tue Apr 27 11:44:48 2021 +0200 committer Luboš Luňák <l.lunak@collabora.com> Thu Apr 29 16:05:53 2021 +0200 do not apply line dashing in drawinglayer (tdf#136957) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114710 Miklos, do you know by any chance someone who might be able to look at this? I did some investigations with the faulty patch. For that, I added a more interesting example document for Impress, that is impress-test.odp. In that document, I simply inserted the SVG image lines.svg (produced using Inkscape) that contains a line with a solid part and a dash part. Looking at the patch https://git.libreoffice.org/core/commit/b71d9a6d15cfb8a50afdea5ac064f40d84c561f8, I found the following: 1. In Impress, opening impress-test.odp and breaking the line makes the dashed part solid. Looking at the patch (the vclmetafileprocessor2d.c part), we see that the graphic object is analyzed in processPolygonStrokePrimitive2D() and the LineInfo structure is set up with dash properties. A comment in the patch says for the LineInfo structure that "// This will be used by setupStrokeAttributes() in cppcanvas." But setupStrokeAttributes() in implrenderer.cxx is not called. So the line dashing is not done. 2. In Impress, opening impress-test.odp and doing Slideshow / Start From First Slide makes the dashed part of the line correctly appearing as dashed. This was indeed the purpose of the patch to fix the issue with wrong line dashing in slideshow mode (see bug #136957). In that case, I found that processPolygonStrokePrimitive2D() is also called and the LineInfo structure is set with dash properties. But now, setupStrokeAttributes() in implrenderer.cxx is called, and the line dashing is correctly done. So, to sum up: - when breaking / converting a dashed line (from an SVG imported image) setupStrokeAttributes() is not called and dashed lines are rendered as solid - when showing the SVG imported image in a slideshow setupStrokeAttributes() is called and dashed lines are correctly rendered I don't have the skills to fix the bug myself, but perhaps these findings could help some developer to fix it? Created attachment 187264 [details]
New example document for Impress
Created attachment 187265 [details]
SVG simple image
Perhaps the author of the patch could solve this bug? Could someone contact him? This bug has an impact on the TexMaths extension (LaTeX equations in LibreOffice). Thanks! Increasing the priority as it's a regression that affects a long-standing, currently maintained extension. Xisco, with Roland's pointers, do you know who might be able to help? Or are you interested yourself? Export to SVG also affected, which can be tested with attachment 184620 [details].
*** Bug 146527 has been marked as a duplicate of this bug. *** Dotted line export affected too, see duplicate bug 146527. (Marked older one as dupe because there's more info here.) *** Bug 148179 has been marked as a duplicate of this bug. *** (In reply to Stéphane Guillou (stragu) from comment #2) > Miklos, do you know by any chance someone who might be able to look at this? Sorry, I didn't notice this question earlier. I'll ask around. *** Bug 157821 has been marked as a duplicate of this bug. *** (In reply to Stéphane Guillou (stragu) from comment #2) > Bibisected with linux-64-7.1 repo to first bad commit > a8c7987e61bdb4f12f3a84f5df92c1315525f6f7 which points to core commit > b71d9a6d15cfb8a50afdea5ac064f40d84c561f8 which is a cherrypick of [...] The 7.1 commit is actually 57595773df9f89245457443a3def786fa0e70a69. Bug 156160 has the same cause. *** Bug 156160 has been marked as a duplicate of this bug. *** |