Summary: | not all share/gallery/backgrounds bitmaps are available in area image fill dialog | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | minor | CC: | heiko.tietze, kainz.a, samuel.mehrbrodt, serval2412, xiscofauli |
Priority: | low | ||
Version: | 6.1.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 113224 |
Description
Stéphane Guillou (stragu)
2023-03-04 09:54:15 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this. Here's an example to use some already existing images in extras/source/gallery/backgrounds: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d0e65ec5d48a1d1febfe6a2a25df2e6916e2a843 prerequisite: copy extras/source/palettes/standard.sob in a temporary directory and rename it as a zip. - unzip the file - add image file in subdir Pictures - declare the image file in Content.xml - zip the file - rename it with sob extension - put it back into extras/source/palettes/ Steps: - add line include/svx/strings.hrc RID_SVXSTR_BMPXX - add line in svx/inc/strings.hxx RID_SVXSTR_BMPXX_DEF - add the previously added line in arrays RID_SVXSTR_BMP_DEF and RID_SVXSTR_BMP in svx/source/unodraw/unoprov.cxx I can do this but I just need to know: 1) what images include (perhaps we don't want them all) 2) which order I use (for example, perhaps we want "sand-light" next to "sand" for example Remarks 1) I suppose it would be better to have complete rows (meaning at the end, we'd have a number of images which we can divide by 3 so there's no incomplete row) 2) I hope we can use a number greater than 99 without bringing some havoc. Andreas: I put you in cc because perhaps there was good reason we stopped to 30 images. Just for the record, for the test I saved a file using "fence", then I added "sand" before fence in sob file. When I open the test file "fence", fence image displays well and when trying to select another image, LO retrieves the right fence image (which has moved from center of a row to the right of the same row) so it means file doesn't record an absolute pos in the image list and we can reorder the whole list in sob file if needed. Now I wonder why there are png and jpg files, is it on purpose (to show we can use both formats?). Also, if finally we don't want to use all image files, perhaps we should remove the unused ones? This work has been done for bug 103223 with the list of initial patches https://gerrit.libreoffice.org/q/owner:kris.kr296%2540yahoo.in. Don't remember the reason to not trust the Gallery anymore but could imagine it was the customization. In-built Gallery categories are not located in the user-space and neither adding nor deleting items is possible (there should be a bug to make this happen). But the crucial point of the redesign was to have an extendable list of presets. => NAB |