| Summary: | Make Calc text hyperlinks stand out more | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Gabor Kelemen (allotropia) <kelemeng> |
| Component: | Calc | Assignee: | Balázs Varga (allotropia) <balazs.varga991> |
| Status: | VERIFIED FIXED | ||
| Severity: | enhancement | CC: | cno, heiko.tietze, Jeff, vsfoote |
| Priority: | medium | ||
| Version: | 6.2.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=66545 https://bugs.documentfoundation.org/show_bug.cgi?id=156849 https://bugs.documentfoundation.org/show_bug.cgi?id=108180 https://bugs.documentfoundation.org/show_bug.cgi?id=159747 |
||
| Whiteboard: | target:7.6.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 120543 | ||
| Attachments: |
Example file with hyperlink and Hyperlink styled cell
Screenshot of the example file in Calc master Screenphoto of how it looks on my external monitor Different colors The example file under Windows - Light theme The example file under Windows - Dark theme |
||
|
Description
Gabor Kelemen (allotropia)
2023-02-28 09:21:39 UTC
Created attachment 185634 [details]
Screenshot of the example file in Calc master
Created attachment 185635 [details]
Screenphoto of how it looks on my external monitor
Perhaps it's just my monitor, but probably not.
This was originally noticed by a customer of ours.
Created attachment 185640 [details]
Different colors
The link color is read from the OS (svtools/source/config/colorcfg.cxx #430). On my KDE/Breeze it is #2980b9. The official Wikipedia link color is #3366cc, a bit more blueish but still not "out standing". Plus, if we use hard-coded values we loose the system integration (eg. orange link color on some weird theme). OTOH, system colors are designed for a certain background, dark in my case, and do not necessarily suit editing controls.
We also have the underline attribute. And I could imagine this has been omitted intentionally to not clutter the appearances.
Optional? If, as expert option to not pollute the options dialog.
Created attachment 185662 [details]
The example file under Windows - Light theme
Created attachment 185663 [details]
The example file under Windows - Dark theme
There is indeed a bit of difference in color under Windows depending on the light/dark theme setting.
Still: I think adding automatic underlining here would be probably helpful.
I agree that keeping consistent behavior with themes etc is needed. But within that limit, is there a possibility to improve visibility? It's not a strange idea, looking at the current vague situation. We discussed the topic in the meeting. The proposed underlining for links is welcome without an extra option. Possibly easyhackable. Balazs Varga committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/89e65e6afdfc942cf8232886d6703947167eaec3 tdf#153880 sc: Make Calc text hyperlinks stand out more It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: fc6806c4be8585ce0d35a6b581bf8b3dbf858500 CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: threaded Underlining now appears, making the link stand out more under light theme of Windows. Added to https://wiki.documentfoundation.org/ReleaseNotes/7.6#Calc |