Bug 153782

Summary:	Line width name "Double hairline" is duplicated for two different format commands
Product:	LibreOffice	Reporter:	Rafael Lima <rafael.palma.lima>
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	heiko.tietze, samuel.mehrbrodt, serval2412, xiscofauli
Priority:	medium
Version:	7.5.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=48622
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	59284
Attachments:	Screenshot showing the problem

Description Rafael Lima 2023-02-22 13:57:39 UTC

Created attachment 185529 [details]
Screenshot showing the problem

In the Properties sidebar "Cell Appearance" section, the line width selector has 2 repeated entries "Double Hairline". However, since they have a totally different effect, I believe they should have different names.

Based on the code, I suggest they are called:
- Double Thin Line
- Double Thick Line

Notice in the code that none of them are actually drawn as hairlines after SvxBorderLineWidth::Medium / Thick is set.

https://opengrok.libreoffice.org/xref/core/sc/source/ui/sidebar/CellLineStyleControl.cxx?r=cd116a1b#130

See attached image for more information. Notice the difference between the actual hairline with the output of the two commands previously mentioned.

Comment 1 Julien Nabet 2023-02-22 15:16:17 UTC

It makes sense to me but let's ask UI experts.

Comment 2 Heiko Tietze 2023-02-22 16:17:29 UTC

CellLineStylePopup::Initialize() uses STR_BORDER_DOUBLE_1 twice [1]. Any reason, Samuel?

You added this for bug 48622 with https://gerrit.libreoffice.org/c/core/+/124680

[1] https://opengrok.libreoffice.org/xref/core/sc/source/ui/sidebar/CellLineStyleControl.cxx?r=cd116a1b#70

Comment 3 Samuel Mehrbrodt (allotropia) 2023-02-23 07:30:47 UTC

(In reply to Heiko Tietze from comment #2)
> CellLineStylePopup::Initialize() uses STR_BORDER_DOUBLE_1 twice [1]. Any
> reason, Samuel?
> 
> You added this for bug 48622 with
> https://gerrit.libreoffice.org/c/core/+/124680
> 
> [1]
> https://opengrok.libreoffice.org/xref/core/sc/source/ui/sidebar/
> CellLineStyleControl.cxx?r=cd116a1b#70

I think this was a mistake. Probably one of them can go.
Maybe check which makes more sense (also in terms of interoperability) and remove the other one.

Comment 4 Heiko Tietze 2023-02-23 07:37:35 UTC

Rafael, up to you. Either remove the tick one (my take) or keep both and rename as suggested.