| Summary: | Scroll bar not in dark mode when system dark mode enabled | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Faisal <leemcke> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, vsfoote |
| Priority: | medium | ||
| Version: | 7.4.4.2 release | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| Whiteboard: | target:7.6.0 target:7.5.1 target:7.4.6 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 150915 | ||
| Attachments: |
Screenshot showing a light theme scroll bar
scrollbar in similar popdown in visual studio has the same issue |
||
|
Description
Faisal
2023-01-30 08:01:57 UTC
Created attachment 185008 [details]
Screenshot showing a light theme scroll bar
Confirmed with current master against 7.6, the "thumb" fg and the "scroll bar" bg of the scroll bar widget of the Toolbar listboxes and the Sidebar listboxes do not receive the same color handling as the scroll bar widget on the document canvas. Examples: scroll bar for the Page deck's Format -> Size listbox the scroll bar for Font Name, and Font Size listbox Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5e193d854596db714ca786c2a676b5ac9684d5eb CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded I can see it, but I don't know why that is. It's the same code that renders it in either case; (ImplDrawNativeControl in vcl/win/gdi/salnativewidgets-luna.cxx) Created attachment 185023 [details]
scrollbar in similar popdown in visual studio has the same issue
We're not the only application where this oddity occurs, similar happens in the default Windows file dialog as well, e.g. from notepad or visual studio I get a light scrollbar in drop downs where its is dark in the parent dialog.
stumbled on a workaround Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4332c58eca7df7a30e8f11b9193d7d0727c2a36c tdf#153273 bodge dark scrollbar into drop downs It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. looks good for me in trunk now, backports to 7-5 and 7-4 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/5b64ac83cdbab98052c478d5bb6954b324a36171 tdf#153273 bodge dark scrollbar into drop downs It will be available in 7.5.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The scrollbar and thumb (unfocused and focused) are getting color assignment more inline with Windows os/DE in a Dark theme mode. Thanks Caolán Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/165dce050b41c1268a56905986f97263717f1184 tdf#153273 bodge dark scrollbar into drop downs It will be available in 7.4.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |