Bug 152292

Summary: LARGE() and SMALL(): inconsistencies between app and Help pages
Product: LibreOffice Reporter: Stéphane Guillou (stragu) <stephane.guillou>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: UNCONFIRMED ---    
Severity: trivial CC: erack
Priority: medium    
Version: 6.3.6.2 release   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 108827, 152148    

Description Stéphane Guillou (stragu) 2022-11-29 10:53:54 UTC
Description:
Using the English-US locale, we can see inconsistencies between the app (function Wizard and formula editing tooltip) and the documentation.

1) I am not sure if wee need fixing the naming of arguments in the app or in the documentation ("Rank c" in UI vs "RankC"/"Rank_c" in Help)
2) The description of the function in the UI still uses "k-th smallest" even though it doesn't match the argument name


Steps to Reproduce:
1. Open the function wizard from the formula bar
2. Search for "SMALL" (or "LARGE")
3. Click on "SMALL" (or "LARGE") and see the description
4. Open the corresponding help page: https://help.libreoffice.org/latest/en-US/text/scalc/01/04060183.html



Actual Results:
Inconsistencies in function description and argument naming.

In UI:

- Argument is "Rank c"
- Function description refers to value "k"

In documentation:

- Argument is "RankC" or "Rank_c"



Expected Results:
Consistency between syntax and function definition; consistency between UI and Help.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 7830ecc2e4e5dd264517c6554078fa807ff1fceb
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Was already exactly like that in:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Eike Rathke 2022-11-29 11:22:25 UTC
The old parameter name was "Rank_c", we harmonized capitalization of spreadsheet function UI parameter names (there was no common ground whatsoever) and also removed _ underscores some years ago, the Help texts weren't adjusted.

As for LARGE() and SMALL(), speaking of the k-th value is common. If you really want to align that then changing the parameter name from "Rank c" to "k" would be the way to go.

Sometimes it helps to lookup the ODFF definition, e.g.
https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#LARGE
but not in this case as it names it "N" ...