Bug 151859

Summary: Tabbed view does not share colors with the personalization theme.
Product: LibreOffice Reporter: dlem1
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED DUPLICATE    
Severity: normal CC: dgp-mail, dlem1, vsfoote
Priority: medium    
Version: 7.4.2.3 release   
Hardware: All   
OS: Windows (All)   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107237, 125823    
Attachments: The tabs are a different color than the rest of the toolbar
tabbed NB clip of current 7.4 state with experimental features and LO Dark color them with preinstalled area fill theme
Screenshot with experimental feature enabled

Description dlem1 2022-11-02 04:06:08 UTC
Description:
I'm using one of the "preinstalled themes" under the personalization tab in the options menu, and I'd like to use tabbed view as my user interface, however, the tabs have white text on a white background, which doesn't match my chosen theme, and is hard to see.

Steps to Reproduce:
1. Choose Tools > Options > Personalization > Dark
2. Choose View > User Interface > Tabbed 
3. Go blind.

Actual Results:
The Tabs aren't grey like the rest of the toolbar.

Expected Results:
The Tabs should be the same color as the rest of the toolbar.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

I have edited the header and footer PNG files (under the personas > dark folder) to be darker, but it happens with any other "preinstalled theme"
Comment 1 dlem1 2022-11-02 04:09:50 UTC
Created attachment 183370 [details]
The tabs are a different color than the rest of the toolbar

The tabs have white text on near-white background, when the rest of the toolbar is almost black.

I'd like the tabs to share the same white-text-on-black-background colors as the rest of the toolbar.
Comment 2 Dieter 2022-11-15 13:49:57 UTC
I confirm it with

Version: 7.4.3.1 (x64) / LibreOffice Community
Build ID: 3793858a34d8fef5b92f8fee233f97766f05e281
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 3 V Stuart Foote 2022-11-15 18:58:52 UTC
Dupe -- bug 121877

How are things if you enable experimental features checkbox (Tools -> Options -> Advanced panel)?  Support for Windows in 'Dark' color theme is non-experimental at 7.5

Also check out the 'LibreOffice Dark' color theme (Tools -> Options -> Application Colors panel). You can start there and tweak the application colors as you like and save to your own personalized color theme.

Finally, the old Mozilla style "preinstalled themes" for personalization are known to be trouble prone.  Don't use them! Or if you do, limit your expectations. Have bug 125217 open to do something smarter that will be a mix of area fills and application colors.

*** This bug has been marked as a duplicate of bug 121877 ***
Comment 4 V Stuart Foote 2022-11-15 19:10:26 UTC
Created attachment 183611 [details]
tabbed NB clip of current 7.4 state with experimental features and LO Dark color them with preinstalled area fill theme
Comment 5 Dieter 2022-11-15 19:30:00 UTC
Created attachment 183613 [details]
Screenshot with experimental feature enabled

Still not working with

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 55cd20e6228a06836285c14ca6726adb1bb4ffcb
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded
Comment 6 V Stuart Foote 2022-11-15 20:31:19 UTC
(In reply to Dieter from comment #5)
> Created attachment 183613 [details]
> Screenshot with experimental feature enabled
> 
> Still not working with
> 
> Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 55cd20e6228a06836285c14ca6726adb1bb4ffcb
> CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (de_DE); UI: en-GB
> Calc: CL threaded

confirm, but that affect on the MUFFIN NB 'Tabbed' is only for the 'Dark' Preinstalled theme with Win10/11 DE in 'Light' color theme mode--the other flavors of the preinstalled themes don't have fg/bg issue in Windows default 'Light' color theme (their font fg is Dark). Although the 'White' Preinstalled theme is pretty ugly when in windows DE's 'Dark' color theme.

Frankly these "preinstalled themes" are junk and should just be stripped out and replaced with something functional for the LibreOffice's entire UI (bug 125217)--not just UI area fills but handle icon theme and widget coloring (for at least fg/bg). I guess the 'Dark' preinstalled theme could be tweaked to use new fg / bg tests. But the improved Win10/11 DE 'Dark' color theme support makes the 'Dark' preinstalled theme kind of useless.

Anyhow simple work around -- don't use the "Preinstalled themes" and if do, avoid the 'Dark' theme for its fg/bg issues.