Summary: | Font "Base size" reverts to sm config default of 12pt after reloading any formula (OLE object and standalone document) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
Component: | Formula Editor | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | csyu.279, dante19031999, vsfoote, xiscofauli |
Priority: | high | Keywords: | bibisected, bisected, filter:odf, regression |
Version: | 7.5.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.5.0 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: | ODF Formula with a Size {} value and UI Base size |
Description
Mike Kaganski
2022-10-31 11:56:13 UTC
Note that this is a data loss. Also other formula properties are lost: e.g., borders. I was able to reproduce the bug in the unstable build: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded However I was unable to reproduce the bug in the stable build: Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Given that it seems Dante isn't really active today and this is towards some long-term goal, perhaps the best is to revert it for now (if that's reasonably straightforward). (In reply to Miklos Vajna from comment #3) > Given that it seems Dante isn't really active today and this is towards some > long-term goal, perhaps the best is to revert it for now (if that's > reasonably straightforward). Done in https://gerrit.libreoffice.org/c/core/+/143534 Created attachment 183946 [details] ODF Formula with a Size {} value and UI Base size Confirming an issue When using the Size {} notation --XML mystyle "mathsize"-- to set node size persists. As does using the 'Font Size...' dialog to set the "Base size:" value It is recorded to ODF. <config:config-item config:name="BaseFontHeight" config:type="short">80</config:config-item> And it is only on reopening in a master against 7.5 that the default reasserts. The formula opens correctly on 7.4.3 setting expected Base size. =-testing-= Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 958c08ad86d56839faf28a02097500bad7b1eb76 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded @Xisco Not clear simple reversion of that one commit is the best thing here. There were a lot of *additional* changes to the sm import and export framework around https://gerrit.libreoffice.org/c/core/+/120753 It is exporting correctly. Maybe better to let it ride, and tweak the glitch in the importer? (In reply to V Stuart Foote from comment #6) > @Xisco Not clear simple reversion of that one commit is the best thing here. > > There were a lot of *additional* changes to the sm import and export > framework around > > https://gerrit.libreoffice.org/c/core/+/120753 > > It is exporting correctly. Maybe better to let it ride, and tweak the glitch > in the importer? yes, reverting the issue fixes the issue. I think for now it's better to revert it, I can always be reintroduced again in the future Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9939ffb9b87e536b3217232b732218e82126ad6c tdf#151842: Revert "Connect new import / export to starmath" It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/47d549c015d53b84b4f98c144c1b49378d027a4d tdf#151842: starmath_import: Add unittest It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |