Summary: | Lines in Special Characters dialog do not respect dark mode | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Rafael Lima <rafael.palma.lima> |
Component: | Writer | Assignee: | Rafael Lima <rafael.palma.lima> |
Status: | VERIFIED FIXED | ||
Severity: | trivial | CC: | buzea.bogdan, heiko.tietze, vsfoote |
Priority: | low | ||
Version: | 7.3.5.2 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.5.0 target:7.4.3 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 143344, 150915 | ||
Attachments: |
Special Characters dialog (dark mode)
SCD on Windows in Dark color theme SCD in Linux (after the patch) SCD in Linux (after the updated patch) |
Description
Rafael Lima
2022-09-29 17:56:13 UTC
Identical result for Windows 10 in Dark color theme mode, the grid lines in the SCD remain dark. But pretty trivial as they are visible... Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 0d3dd0aa54ad792f91d0905f3d46c13df3512d89 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Created attachment 182738 [details]
SCD on Windows in Dark color theme
Created attachment 182756 [details] SCD in Linux (after the patch) Proposed patch at: https://gerrit.libreoffice.org/c/core/+/140759 Here's a screenshot of how the dialog looks after the patch. Created attachment 182757 [details]
SCD in Linux (after the updated patch)
Here's a new screenshot with an updated version of the patch.
Notice that it now fixes the character view at the top-right corner.
(In reply to Rafael Lima from comment #4) > Created attachment 182757 [details] > SCD in Linux (after the updated patch) > > Here's a new screenshot with an updated version of the patch. > > Notice that it now fixes the character view at the top-right corner. Nice, thanks! LGTM too Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3e4697c7675430f5e4e2221c951971caee0bdeb8 tdf#151232 Fix lines in Special Characters dialog in dark mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rafael Lima committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/19b650dd49620f699b695fb95679284be509ef2e tdf#151232 Fix lines in Special Characters dialog in dark mode It will be available in 7.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified. Confirm it is solved It's ok in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a36173359d4614a8935e2f764acadfcf736e091c CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Was NOT ok in Version: 7.4.0.2 / LibreOffice Community Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded |