Summary: | export of table in frame in table in header silently drops inner table | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Caolán McNamara <caolan.mcnamara> |
Component: | Writer | Assignee: | Mike Kaganski <mikekaganski> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | michael.stahl, mikekaganski, rafael.palma.lima |
Priority: | medium | Keywords: | dataLoss |
Version: | 7.2.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=124470 https://bugs.documentfoundation.org/show_bug.cgi?id=137103 https://bugs.documentfoundation.org/show_bug.cgi?id=151100 |
||
Whiteboard: | odf target:7.5.0 target:7.4.2 target:7.3.7 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
demo
Demo saved in 7.0.0 - ready to test |
Description
Caolán McNamara
2022-09-13 10:28:22 UTC
Created attachment 182403 [details]
demo
need to select "TABLE" here and use table, insert table and then try to export as odt (will assert in trunk, but 7.2/7.3 don't) and then reload and inner table is missing
Created attachment 182407 [details] Demo saved in 7.0.0 - ready to test This is the demo from comment 1, with the steps followed, saved in 7.0.0 - so the inner table is saved correctly. Now only save it in later versions and reload, to see the innermost table loss. Repro with Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded Also repro with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 641d92a73e5b3d0e062e16ed4b42236e1a4796a5 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded The inner table indeed disappears after saving it as ODT and reopening the file. Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/58cb4fc7d17ae5b339c5ed6ae139e6ef2433c927 tdf#150927: properly handle nesting in tables It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/ec447be0adc32a16af02732fab4af22bc17e02cd tdf#150927: properly handle nesting in tables It will be available in 7.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/c43b50bf027def7054bc15187d61d61d9b132bd7 tdf#150927: properly handle nesting in tables It will be available in 7.3.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I don't know if its a different problem, but FWIW https://bugs.documentfoundation.org/attachment.cgi?id=148210 (from bug 122628) still asserts on export to odt (In reply to Caolán McNamara from comment #8) As you mentioned, > This asserts in trunk since https://gerrit.libreoffice.org/c/core/+/127548 The export of master styles (note that it's not content) started to require that *autostyles* are already collected, which is IMO wrong (autostyles should refer to styles) after that change. If there is a need to re-arrange the export logic because of that change, I suppose Vasily or Michael know the context of their change better; but I suggest that the rest is a separate bug. (In reply to Mike Kaganski from comment #9) > (In reply to Caolán McNamara from comment #8) > > As you mentioned, > > > This asserts in trunk since https://gerrit.libreoffice.org/c/core/+/127548 > > The export of master styles (note that it's not content) started to require > that *autostyles* are already collected, which is IMO wrong (autostyles > should refer to styles) after that change. If there is a need to re-arrange > the export logic because of that change, I suppose Vasily or Michael know > the context of their change better; but I suggest that the rest is a > separate bug. it's rather non-obvious but this is expected: master styles contain part of the page styles (style:master-page), with their headers/footers that have text content, and this content may of course use automatic styles. perhaps this is why the master-styles element exists, and the master-page element is separate from the page style (style:style family="page")? thanks for fixing this in any case. (In reply to Caolán McNamara from comment #8) > I don't know if its a different problem, but FWIW > https://bugs.documentfoundation.org/attachment.cgi?id=148210 (from bug > 122628) still asserts on export to odt exports fine here with commit 21d93d8d2ffd9c5d5cfe9064590b35e0727295c9 guessing it was bug 151100 |