Bug 150607

Summary:	The string "Enable rounding" is potentially wrong
Product:	LibreOffice	Reporter:	Tuomas Hietala <tuomas.hietala>
Component:	UI	Assignee:	BogdanB <buzea.bogdan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	buzea.bogdan, mentoring
Priority:	medium	Keywords:	difficultyBeginner, easyHack, skillDocumentation, skillUI
Version:	7.2.7.2 release
Hardware:	All
OS:	All
Whiteboard:	target:7.5.0
Crash report or crash signature:		Regression By:

Description Tuomas Hietala 2022-08-25 13:54:36 UTC

Description:
This UI string says "Enable rounding": https://translations.documentfoundation.org/translate/libo_ui-master/scmessages/en/?checksum=2034f0fa344b5902

However, its extended tip says "Truncate the number to a given number of Decimal Places.": https://translations.documentfoundation.org/translate/libo_ui-master/scmessages/en/?checksum=dd095553d6c77da1

Truncation and rounding are different things, so one of the two strings is wrong (I don't know which): https://www.ualberta.ca/computing-science/media-library/teaching-resources/java/truncation-rounding.html

Steps to Reproduce:
1. Compare the strings in the description


Actual Results:
The term "rounding" is used in one string while "truncation" in the other.

Expected Results:
Both strings should use the same term, depending on whether LO actually does rounding or truncation in this case.


Reproducible: Always


User Profile Reset: No



Additional Info:
n/a

Comment 1 Mike Kaganski 2022-08-25 15:00:33 UTC

"Rounding" is the correct term (the code that does that is at [1]).

Changes needed in the code [2] and in help [3].

[1] https://opengrok.libreoffice.org/xref/core/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx?r=14cfff50#283
[2] https://opengrok.libreoffice.org/xref/core/sc/uiconfig/scalc/ui/randomnumbergenerator.ui?r=5143de38&mo=22288&fi=410#409
[3] https://help.libreoffice.org/7.4/en-US/text/scalc/01/02140700.html?DbPAR=CALC#hd_id2308201415431875641

Comment 2 Commit Notification 2022-11-11 06:22:16 UTC

Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/3e98ce658dee0b8b8d017d97da4a817b84156de0

tdf#150607 Change Truncate to Round

Comment 3 BogdanB 2022-11-11 06:35:17 UTC

I will mark the bug as resolved when core gerrit will be merged.

Comment 4 Commit Notification 2022-11-11 09:41:23 UTC

Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cbb83463513431907317bd1b5ab9d1849a4c96af

tdf#150607 Change Truncate to Round

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.