Summary: | Freeze XXX commands in tabbed interface appear twice | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Rafael Lima <rafael.palma.lima> |
Component: | Calc | Assignee: | Rafael Lima <rafael.palma.lima> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | heiko.tietze, kainz.a, nnamani.ezinne |
Priority: | medium | ||
Version: | 7.3.5.2 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.6.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 107237 | ||
Attachments: |
Screenshot showing the problem
Screenshot of the proposed fix Command name changed to Freeze Panes |
Description
Rafael Lima
2022-08-18 14:03:35 UTC
Reproducible in: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: a9d225df2f8772e21435523ca20df1ece37390e4 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: pt-BR (en_NG); UI: en-US Calc: threaded "Freeze Rows and Columns" (.uno:FreezePanes) makes the selection sticky while "Freeze First Column/Row" (.uno:FreezePanesColumn/.uno:FreezePanesRow) applies to the first column/row only. But I admit, it's a bit awkward to cramp every command into the UI. If we remove one of the options we have to provide some access to it, eg. via drop down menu. The topic was on the agenda of the design meeting but didn't receive further opinions. My recommendation: Drop the "Freeze Rows and Columns" (.uno:FreezePanes), at least as first and most prominent control, and keep the two other. Whether toolbar or notebookbar, it should provide quick access to functions - and more options with secondary access methods. (In reply to Heiko Tietze from comment #3) > My recommendation: Drop the "Freeze Rows and Columns" My reaction was the opposite. Drop the very specific/limiting "freeze first" choices and keep the generic "Freeze Rows and Columns" that can accomplish everything desirable by the user. Created attachment 186262 [details] Screenshot of the proposed fix Proposed patch here: https://gerrit.libreoffice.org/c/core/+/149650 I've attached a screenshot of how it looks like with the patch. (In reply to Rafael Lima from comment #5) > Created attachment 186262 [details] > Screenshot of the proposed fix Can you change the label so it wont occupy that much space? Created attachment 186286 [details]
Command name changed to Freeze Panes
How about this? I changed the command label to "Freeze Panes", which is also the name of the Uno command (".uno:FreezePanes")
I should disclose that this is also the label used in MSO.
(In reply to Rafael Lima from comment #7) > How about this? Much better. If you changed the UNO command please double-check how it is used in the UI. (In reply to Heiko Tietze from comment #8) > If you changed the UNO command please double-check how it is used in the UI. I did that. The only place where it looked odd was in the View menu (using the menubar). To fix that, I set the command Label as "Freeze Panes" (which is what we see in the Tabbed UI), but set the command ContextLabel to "Freeze Rows and Columns", so in the menu and context menus, the text shown remains "Freeze Rows and Columns". Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/04ed7cbe53243a042ceeecc62212e73a910d7aef tdf#150471 Remove duplicated Freeze commands from the Tabbed UI It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |