Summary: | Text labels in About dialog became to have different size | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Roman Kuznetsov <79045_79045> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | ASSIGNED --- | ||
Severity: | minor | CC: | 79045_79045, fitojb, vsfoote |
Priority: | medium | Keywords: | bibisected, bisected |
Version: | 7.5.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=150045 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | Adolfo Jayme Barrientos | |
Bug Depends on: | |||
Bug Blocks: | 103202 | ||
Attachments: |
Scrrenshot with the problem
How should About dialog looks Help -> About dialog with new font size changes, seem to have some padding issues |
Description
Roman Kuznetsov
2022-08-10 17:19:36 UTC
Created attachment 181690 [details]
Scrrenshot with the problem
Created attachment 181691 [details]
How should About dialog looks
Looks intentional, per see also? => NAB ? Although the difference in font sizes seems a bit too much--IIUC in the commit [1] the larger is 110% the smaller are set 90% Maybe tweak to a 105% and 95% split? =-ref-= https://gerrit.libreoffice.org/c/core/+/137618 (In reply to V Stuart Foote from comment #3) > Looks intentional, per see also? => NAB ? Looks ugly, if it was made intentional then please change it to back (In reply to Roman Kuznetsov from comment #4) > (In reply to V Stuart Foote from comment #3) > > Looks intentional, per see also? => NAB ? > > Looks ugly, if it was made intentional then please change it to back Why, premise of the see also is valid. Just the delta between the primary and secondary/explanative labeling is a bit too large for the about dialog's aboutdialog.ui I didn't look at the other labeling affected, but maybe elsewhere will need a tweak as well? Created attachment 181695 [details]
Help -> About dialog with new font size changes, seem to have some padding issues
@Adolfo, the size 110% / 90% seems fine in this Windows build. But the total About dialog size and the padding seem a bit off. Clip of recent master, 7.4.02 and a 7.3.5.2 install on the same system.
> Looks ugly Roman, that was how others designed that dialog since version 4.0.x, IIRC, and I just restored that, so I don’t understand the knee-jerk reaction. > Maybe tweak to a 105% and 95% split? This won’t work; I had already tested that. I’ll just drop the 1.1 size increase. … and will properly align the labels at the bottom; thanks for noticing Stuart! (In reply to Adolfo Jayme Barrientos from comment #7) > that was how others designed that dialog since version 4.0.x, IIRC, > and I just restored that This is not quite correct. If you take a screenshot of About dialog from v.6.4, the last version that used the older layout, with the different font sizes, and a screenshot of the About dialog from, say, v.7.4, the last one using the fonts changed in the discussed patch, then you can compare the fonts by pixel. You can, e.g., copy a region with "This release was supplied by The Document Foundation.", used in the both, and put atop of the corresponding text on the other screenshot, and compare by pixel, to see that they are identical (completely identical) in size. So the *smaller* text prior to the 7.0 change was the same size as the whole text in 7.0+. Now if you do the same comparison to 7.5, you see that the text decreases the size. This size had never been used, including 4.0, and so it is definitely not a restoration of a pre-existing design. Also: I do not see a single complaint from any user about unsatisfactorily large font size in dialogs. I see complaints started arriving about the About dialog, the Function Wizard dialog, etc. The change, even if motivated by "let's restore an old design", needs at least "it does not make UX worse" justification. If wanted, the restoration of the pre-7.0 design can only use numbers *larger* than 100%, and never smaller. |