Summary: | Small Caps toolbar button invalidly grayed out | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Eyal Rozenberg <eyalroz1> |
Component: | Impress | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | buzea.bogdan, caolan.mcnamara, raal |
Priority: | medium | ||
Version: | 7.2.3.2 release | ||
Hardware: | All | ||
OS: | Linux (All) | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=147732 https://bugs.documentfoundation.org/show_bug.cgi?id=157358 |
||
Whiteboard: | target:24.8.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 84909 |
Description
Eyal Rozenberg
2022-05-31 20:01:31 UTC
I should mention that, in LO Writer, the toolbar button is not grayed out and works fine. Reproducible with: Version: 7.2.3.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 1; OS: Linux 5.3; UI render: default; VCL: gtk3 Locale: es-MX (es_ES.UTF-8); UI: en-US Calc: threaded Confirm Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: d4123356c61db269651e950a0a2cc93e6d801c90 CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo Small capitals is also greyed out in menu Format > Text > Small capitals @Caolán, is it related to bug 91932? With https://bugs.documentfoundation.org/show_bug.cgi?id=98367 now (hopefully) fixed this should be possible to do now See: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d378cd2f766eeb1fd1c98f62c9ae6b5b59fd00f1 for the original writer implementation and grep for SID_SET_SUB_SCRIPT to see a similar case to model this on Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f7ca5ce78f98505cd301f6bddde143e3ecb846e7 Resolves: tdf#149409 enable impress 'Small Capitals' Toolbar Button It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Seems to work for me now with that. (In reply to Commit Notification from comment #5) Code replication is fun :-) Is it like this with most toolbar buttons available across the LO modules? Anyway, thanks for the fix, I'll try it in a day or two with a nightly. Eyal and Caolan, thanks. Bad in 24.2 (for comparison reason) Version: 24.2.0.2 (X86_64) / LibreOffice Community Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Active in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c249e910992d5da840989a1f2bea9da1c6d0fcbb CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded |