Summary: | Increase/Decrease indent buttons should be part of the Text Formatting toolbar | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Eyal Rozenberg <eyalroz1> |
Component: | Impress | Assignee: | BogdanB <buzea.bogdan> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | CC: | 79045_79045, buzea.bogdan, heiko.tietze, mentoring |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillDesign, topicDesign |
Version: | 7.4.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=149307 https://bugs.documentfoundation.org/show_bug.cgi?id=67622 |
||
Whiteboard: | target:7.5.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 84909 | ||
Attachments: | screenshot |
Description
Eyal Rozenberg
2022-05-26 08:58:01 UTC
Oh, but - this is all relevant only if one can increase/decrease the independent of individual paragraphs; until that's possible, putting these on the toolbars is not very useful. (In reply to Eyal Rozenberg from comment #1) Ignore that comment, but do look at bug 149307 The Text Formatting toolbar is quite large as it is and we should aim to keep the size of visible buttons below 1280px. But I thing the two buttons fit into the limit and could be of use for the toolbar-lovers. Ideally the toolbar is harmonized as best as possible with Writer. Code pointer: sd/uiconfig/simpress/toolbar/textobjectbar.xml sd/uiconfig/sdraw/toolbar/textobjectbar.xml .uno:IncrementIndent .uno:DecrementIndent Heiko, icons in the toolbar have a different order in Writer and Impress. For example in Impress we have Bullets, Alignment, Increase/Decrease paragraph, but in Writer we have Alignment, Bullets, Increase/Decrease Indent, Increase/Decrease paragraph. So I would like also here to move Bullets from begining after alignment in order to harmonize toolbars between all Writer/Impress/Draw. Sounds like a plan (and a minor change in case of list on/off). In general, consistency is good but we should carefully check if the use case exists in the respective module. (In reply to Heiko Tietze from comment #5) Agreed. I also suggest that the rationale for rearranging the buttons be mentioned in the commit message. ... maybe the rationale for the existing order is mentioned somewhere in there too? I wonder. (In reply to Eyal Rozenberg from comment #6) > (In reply to Heiko Tietze from comment #5) > Agreed. I also suggest that the rationale for rearranging the buttons be > mentioned in the commit message. ... maybe the rationale for the existing > order is mentioned somewhere in there too? I wonder. Ok, I will do that, I will explain the need for keeping the harmoinzed order between Writer, Impress and Draw. From my point of view Writer is the main app that is used, and after that less and less the others (Impress, Calc). So, if users are more used to Writer I would keep the Writer order, and the rest I will rearange based on that. Created attachment 183543 [details]
screenshot
By default Draw and Impress don't have this Text Formatting activated, so the impact of the changes would be minimum. Also, the changes are just about 2-3 icons, icons that are included in all 3 toolbars.
See a screenshot with the current situation.
(In reply to BogdanB from comment #8) > By default Draw and Impress don't have this Text Formatting activated, so > the impact of the changes would be minimum. It's a good change, no need to justify it further... About the activation of this toolbar, see also bug 38850. If you're looking for something to work on after this issue, that would be much appreciated :-) Yes, I would like something to work on, similar to this, but I don't have cpp knowledge. So just something easy to read as for a beginner. (In reply to Eyal Rozenberg from comment #9) > (In reply to BogdanB from comment #8) > > By default Draw and Impress don't have this Text Formatting activated, so > > the impact of the changes would be minimum. > > It's a good change, no need to justify it further... > > About the activation of this toolbar, see also bug 38850. If you're looking > for something to work on after this issue, that would be much appreciated :-) Title of 38850 is "In Tools > Options > View - add an option to control appearance of context-sensitive toolbars". I can not work on this. Is more than UI. Bogdan B committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/458dac8b76cafe8559b80bf9b36a2ac012b9c52f tdf#149305 Add indent button in text toolbar and change buttons order It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Bogdan! |