Summary: | Accessibility Checker does not check for title property containing only white space | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Christophe Strobbe <c_strobbe-fdo> |
Component: | Writer | Assignee: | Hao Liu <ianahao331> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | dgp-mail, heiko.tietze, mentoring |
Priority: | medium | Keywords: | accessibility, difficultyBeginner, easyHack, skillCpp |
Version: | 7.1.4.2 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.5.0 target:7.4.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 101912, 108747 |
Description
Christophe Strobbe
2022-05-16 21:08:41 UTC
I confirm it with Version: 7.3.4.1 (x64) / LibreOffice Community Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL I would consider this as a bug => NEW But let's have a double-check from the design-team cc: Design-Team Well silence is a pointless title for a reader. So yes, let's trim the white space before checking emptiness. Code pointer: sw/source/core/access/AccessibilityCheck.cxx -> class DocumentTitleCheck Liu Hao committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/af87ec3137c32ba098c072304595d8b590f3447c tdf#149115 Trim the white sapce in title before emptiness check It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Liu Hao committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/658cb77de90ec66abc6d0ed4aba614772ae482bd tdf#149115 Trim the white sapce in title before emptiness check It will be available in 7.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. VERIFIED with Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c3b5eea4304ad6815b491f549fce008a9630c213 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Liu Hao, thank you for fixing this issue! |