Summary: | Writer Crash on loading files with RTL/CTL text and certain glyphs (debug build only) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Hossein <hossein> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | VERIFIED FIXED | ||
Severity: | major | CC: | aron.budea, caolan.mcnamara, hossein, l.lunak, telesto, xiscofauli |
Priority: | high | Keywords: | bisected, haveBacktrace, regression, text:ctl, text:rtl |
Version: | 7.4.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=150138 | ||
Whiteboard: | target:7.4.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 105537, 112810 | ||
Attachments: |
Text layout bug that leads to crash
Backtrace |
Description
Hossein
2022-05-05 23:19:52 UTC
Created attachment 179952 [details]
Backtrace
Backtrace for the crash while loading laypout-bug.odt
The crash happens in:
soffice.bin: vcl/source/gdi/impglyphitem.cxx:277: void checkGlyphsEqual(const SalLayoutGlyphs&, const SalLayoutGlyphs&): Assertion `l1->isEqual(l2)' failed.
Unspecified Application Error
Fatal exception: Signal 6
yeah, I see this also with https://bugs.documentfoundation.org/attachment.cgi?id=179385 and cursoring through the first and second lines Bisected to: 0a6d946694e4fcb39228c5e1fec58fcfd8a45989 is the first bad commit commit 0a6d946694e4fcb39228c5e1fec58fcfd8a45989 Author: Luboš Luňák <l.lunak@collabora.com> Date: Wed Apr 27 09:52:04 2022 +0200 optimize repeated calls for the same string in SalLayoutGlyphsCache Luboš Luňák committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5caa7f44b861876afa5b3b8f71e3848abd8875e6 fix HB_GLYPH_FLAG_UNSAFE_TO_BREAK for RTL in cloneCharRange() (tdf#148954) It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I verify that the crash no longer happens with the latest patch from Luboš. I have also tested with another big Persian document. LibreOffice was crashing before, and now it loads the file without crash. |