Bug 148685

Summary:	FILEOPEN PPTX: Underlining color wrong
Product:	LibreOffice	Reporter:	Timur <timur>
Component:	Impress	Assignee:	Xisco Faulí <xiscofauli>
Status:	VERIFIED FIXED
Severity:	normal	CC:	gang65, xiscofauli
Priority:	medium	Keywords:	filter:pptx
Version:	Inherited From OOo
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=65278 https://bugs.documentfoundation.org/show_bug.cgi?id=104219
Whiteboard:	target:7.4.0 target:7.3.4
Crash report or crash signature:		Regression By:

Description Timur 2022-04-20 13:17:31 UTC

This bug is about saving underline to PPTX. 

1. Open ODP attachment 158004 [details] (mentioned in bug 130498 but it didn't belong there)
2. Save as PPTX 
3. Reopen in MSO, see it's correct, so filesave should be OK.
4. Reopen in LO, see wrong underline colors, so bug is fileopen. 

I quote "Problem with the underline colour goes back to https://cgit.freedesktop.org/libreoffice/core/commit/?id=8129ad7b22dceeb2fef13741aa509c2229cf03de" meaning it is differently wrong from LO 5.4 and bug 104219 and also differently wrong from LO 5.0 and bug 90828.

I don't see a problem with saving ODP attachment 179681 [details] for PPT bug 65278 where underlining is split.

Comment 1 Xisco Faulí 2022-04-20 13:42:46 UTC

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 8e4453c2117b6c3bb15be6b949a0a8a43df66647
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

Comment 2 Xisco Faulí 2022-04-20 15:04:08 UTC Comment hidden (obsolete)

I think I know how to fix it

Comment 3 Xisco Faulí 2022-04-21 11:05:24 UTC

meh, I don't know how to fix it.
I believe the value should be reset in https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/textcharacterproperties.cxx?r=678790f2#203.
I tried with https://gerrit.libreoffice.org/c/core/+/133219 but failed

Comment 4 Timur 2022-04-21 13:01:00 UTC

Hi Bartosz. Your commit made a change here, not a regression, but please see.

Comment 5 Xisco Faulí 2022-04-22 16:36:38 UTC

Ok, I know how to fix it

Comment 6 Commit Notification 2022-04-22 17:38:43 UTC

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1c924efe1f80207a5e104d755615b1eb9a91d418

tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor properties

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Commit Notification 2022-04-23 11:03:31 UTC

Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/696677a36182062dfa3d157130904a6cf9fc73b1

tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor properties

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 8 Timur 2022-04-25 08:45:07 UTC

Seems good both in LO and MSO. 
Very nice when "Inherited from OO" is fixed.