Bug 146532

Summary:	Updating DDE links should dirty the document
Product:	LibreOffice	Reporter:	gmarco <gmmellina>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	minor	CC:	aron.budea, gmmellina, himajin100000, ilmari.lauhakangas, miguelangelrv
Priority:	low
Version:	7.2.4.1 release
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112581, 116625
Attachments:	calc sample test writer sample test

Description gmarco 2022-01-02 22:19:04 UTC

Now, with L.O. 7.2.4.1, the connection works correctly again.
There remains a minor bug that I had already reported in the past.
When opening a text document that has links to scalc files embedded, you are asked if you want to update it or not (in the meantime the data in the spreadsheet may have changed).
Choosing "YES" the embedded object will reflect the current state of the data in the spreadsheet.

At this point, closing the ODT file, the bug can occur if the closing is performed by clicking on "X" as commonly used.

a) if the document has not been further edited (changes to the actual text), the closure takes place without saving (and this without even a warning) losing the upgrades.

b) the problem does not occur in all other cases:
- the text has also been changed
- the embedded ODS data has been updated manually from "Edit> Links to external files ..." (Update button)
- close the ODT file with "Save" or "Save with name".

Question: is this a bug? or is the fact intentional? in the latter case, I think it would be right to indicate it and prevent possible damage with a warning.

Comment 1 m_a_riosv 2022-01-03 22:56:09 UTC

If it is already reported, add in that one, that bug still remains, adding the information about the last version tested. Se we can close this one as dupliclate.

Comment 2 gmarco 2022-01-04 08:35:42 UTC

Referring to the "X" question, where is it reported?
If you intend my original bug 91817, that is dated 2015-06-02 but the problem is already here.

Comment 3 QA Administrators 2022-01-05 03:40:58 UTC Comment hidden (obsolete)

[Automated Action] NeedInfo-To-Unconfirmed

Comment 4 Buovjaga 2022-12-17 15:10:03 UTC

(In reply to gmarco from comment #0)
> a) if the document has not been further edited (changes to the actual text),
> the closure takes place without saving (and this without even a warning)
> losing the upgrades.

Repro from scratch. Changed summary to reflect this better.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b46020c262045aed0beace4708565235c2523cc
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo

Comment 5 gmarco 2022-12-18 09:48:44 UTC

Created attachment 184217 [details]
calc sample test

Comment 6 gmarco 2022-12-18 09:49:54 UTC

Created attachment 184218 [details]
writer sample test

Comment 7 gmarco 2022-12-18 09:52:43 UTC

(In reply to Buovjaga from comment #4)
> (In reply to gmarco from comment #0)
> > a) if the document has not been further edited (changes to the actual text),
> > the closure takes place without saving (and this without even a warning)
> > losing the upgrades.
> 
> Repro from scratch. Changed summary to reflect this better.
> 

Now in LibreOffice 7.3.7 nothing changed!

For a better understanding of the problem, I am attaching the two examples (.ods and .odt) containing explanatory NOTES.
Try opening the .odt file without choosing to update it, then close and reopen it choosing to update, then close it by clicking on "X" and verify that it has not been updated.
Subsequently, reopening it with update, close it with "save" and verify that it has been updated.