Bug 146421

Summary: Sidebar: Rearrange controls in the Alignment section
Product: LibreOffice Reporter: andreas_k <kainz.a>
Component: CalcAssignee: andreas_k <kainz.a>
Status: VERIFIED FIXED    
Severity: normal CC: buzea.bogdan, heiko.tietze, kainz.a, vsfoote
Priority: medium Keywords: topicUI
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard: target:7.4.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103459    
Attachments: Alignment Sidebar rework
Left: Before / Right: After

Description andreas_k 2021-12-26 12:27:15 UTC
Created attachment 177139 [details]
Alignment Sidebar rework

The Calc Alignment sidebar was shown at the default sidebar layout. So it's a very important element.

The guideline for sidebar say:
- left align: string
- right align: widget

The Sidebar in master is a compromise of sidebar height so the two checkboxes are within one row. Which cause problems when the translation string of any of the two elements is to long.

my suggested change is, to make the alignment section according to the LibO guidelines for sidebar.

- left align: string
- right align: widget
- all widget use the same width
- one command per row (like in the Number Format section)
- good grouping of commands for better visibility.
Comment 1 andreas_k 2021-12-26 12:41:38 UTC
Created attachment 177140 [details]
Left: Before / Right: After
Comment 2 V Stuart Foote 2021-12-26 15:01:26 UTC
reasonable, +1
Comment 3 Heiko Tietze 2022-01-03 13:26:14 UTC
Sounds like a good improvement. Want to do it yourself or should I add information how to easyhack this?
Comment 4 Commit Notification 2022-01-16 21:35:51 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7a2042dc00c72ac074a21c2c324ace5eac89a5f0

tdf#146421 Calc Sidebar Alignment Section follow arrangement guideline

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Heiko Tietze 2022-01-17 08:39:52 UTC
Resolve fixed?
Comment 6 andreas_k 2022-01-17 13:21:03 UTC
verified and work well.
Comment 7 BogdanB 2022-01-26 15:17:48 UTC
Thanks, nice visual improvment

Verified in
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 0c3b8792b712e939d2ad524d554f96616b4844be
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded