Bug 145030

Summary: UI: Add animation (+) sign still enabled mode with deselect text frame because of using remove effect (-)
Product: LibreOffice Reporter: Telesto <telesto>
Component: ImpressAssignee: Caolán McNamara <caolan.mcnamara>
Status: RESOLVED FIXED    
Severity: normal CC: caolan.mcnamara, heiko.tietze
Priority: medium    
Version: 4.0.0.3 release   
Hardware: All   
OS: All   
Whiteboard: target:7.3.0 target:7.4.0 target:7.3.1
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103437, 103459    

Description Telesto 2021-10-10 07:14:56 UTC
Description:
UI: Add animation (+) sign still active with deselect text frame because of using remove effect (-)

Steps to Reproduce:
1. Open Impress (ignore wizard
2. Select at text frame
3. Sidebar -> Animation tab
4. Press + sign
5. Press - sign
6. Notice + sign still being black (not grayed out) whereas the blue selected frame has vanished. And + press being without effect

Actual Results:
+ sign enabled 

Expected Results:
+ sign disabled


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 93115d2c54d645bcf2f80fde325e3ede39dee4d5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-10-10 07:17:52 UTC
Also in
Version: 6.3.7.0.0+ (x86)
Build ID: 726535ec30f12697ceccd2f0640d9371a64dc5bd
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

and in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

also in
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)
Comment 2 Telesto 2021-10-10 07:18:19 UTC
@Heiko
EasyHack?
Comment 3 Heiko Tietze 2021-10-11 07:00:13 UTC
(In reply to Telesto from comment #2)
> EasyHack?

The right solution is not to disable the Add button (it's working properly when clicking within the slide) but to keep the active selection. That's barely an easyhack. But Caolan did a lot here too, maybe he has an idea.

Confirming the usability issue => NEW
Comment 4 Commit Notification 2021-10-11 16:22:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ba535d8cbda1026823ce9796c20f97b7367d581f

tdf#145030 resync with empty selection if we unselected everything

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-02-01 08:37:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8a1825bf896c8004a10275d93a626e472a52966c

Revert "tdf#145030 resync with empty selection if we unselected everything"

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-02-01 08:38:47 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4fa6ed7b0902e08de006bcb7534ba49696affb9f

tdf#145030 if all in effects list is unselected retain last marked obj

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2022-02-01 08:51:50 UTC
finally landed on leaving the last selection in the slide alone when the last item in the effect list is unselected from the list, done in trunk backport to 7-3 in gerrit
Comment 8 Commit Notification 2022-02-01 16:44:44 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9dc666afc81ec61c6ac3131fb13d6025433dd3b6

tdf#145030: sd: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-02-07 16:05:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/bafdd5446402b81ae500902370102535bb5eb28e

Revert "tdf#145030 resync with empty selection if we unselected everything"

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-02-07 16:06:16 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/c67abb385fbc1d601aee2fc693f440bbdfd26760

tdf#145030 if all in effects list is unselected retain last marked obj

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.