Bug 144609

Summary:	Numbering is unseen with prefix text
Product:	LibreOffice	Reporter:	Pierre C <pierre.choffardet>
Component:	Writer	Assignee:	Vasily Melenchuk (CIB) <vasily.melenchuk>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kelemeng, pierre.choffardet, raal, telesto, vasily.melenchuk
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.2.1.1 rc
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=147937
Whiteboard:	target:7.3.0 target:7.2.3
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103369
Attachments:	test document

Description Pierre C 2021-09-19 16:41:07 UTC

Created attachment 175122 [details]
test document

Step to reproduce
Open attached file and compare the the text with the first screen copy
First part of the file is the text with the problem

then two screen copies

First image the correct behaviour. So the text upper should be the same

Second image is the bug, you can see the differences

This bug seems to be same as :
https://bugs.documentfoundation.org/show_bug.cgi?id=143784

Comment 1 Telesto 2021-09-20 07:14:19 UTC

Repro
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d5e55d204b71710eb5eb5d2c683dd6698626df3c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

not with
Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

Comment 2 raal 2021-09-25 14:59:50 UTC

This seems to have begun at the below commit.
Adding Cc: to Vasily Melenchuk; Could you possibly take a look at this one?
Thanks
linux-64-7.3 a8c3958a1f32014408898bac7ce3a1106aee86c6 is the first bad commit
commit a8c3958a1f32014408898bac7ce3a1106aee86c6
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sun Aug 8 23:34:08 2021 +0200

    source d1f1f546b212ecd651146addeb328806bb270d5f

https://gerrit.libreoffice.org/c/core/+/120082
   sw: numbering rule is not constructed for numbering type "None"

Comment 3 Vasily Melenchuk (CIB) 2021-09-25 16:12:29 UTC

Yeah. I confirm it.
It looks like I was not correct with fix in tdf#143605: it should be not empty, but display a single dot remaining from prefix/suffix. Fix for this problem is in progress.

Comment 4 Commit Notification 2021-10-04 13:29:56 UTC

Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/66a7f8a49d2db1829dd533f32ae5818499f8544b

tdf#144609: numbering "None" should still show prefix/suffix

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 5 Commit Notification 2021-10-05 08:19:03 UTC

Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/a1692118d41a37282511c688b0062109c1b1e440

tdf#144609: numbering "None" should still show prefix/suffix

It will be available in 7.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.