Summary: | Closing Mail merge wizard removes its data source from Registered databases | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, caolan.mcnamara, nemeth, varga.balazs3 |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 6.4.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=118634 | ||
Whiteboard: | target:7.3.0 target:7.2.3 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 102998 | ||
Attachments: |
Screenshot of the attachment 174941 in Writer
Opening the Mail Merge wizard Screenshot of the problem in Writer with the data source gone attachment 174941 saved without the data source |
Description
NISZ LibreOffice Team
2021-09-16 08:08:42 UTC
Created attachment 175050 [details]
Opening the Mail Merge wizard
Created attachment 175051 [details]
Screenshot of the problem in Writer with the data source gone
Created attachment 175052 [details] attachment 174941 [details] saved without the data source reverting that patch a 6-4 tree does change how it behaves so I can confirm that looks like its the preview widget which uses a writer document deregisters it but it also looks like this just didn't happen before this commit because of a leak and a missing dtor call for the preview widget https://gerrit.libreoffice.org/c/core/+/122763 is my stab at resolving this Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c9a405b3bcc0d3f5fdb6b4386831a4d4b2897c74 tdf#144532 closing mail merge wizard preview removed document's data source It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. this appears to work in trunk, backport to 7-2 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/83876642498b0203b25b8b95e612603d46addd62 tdf#144532 closing mail merge wizard preview removed document's data source It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |