Summary: | FILEOPEN PPTX: shadow effect for tables partly incorrect | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Gerald Pfeifer <gerald> |
Component: | Impress | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, timur |
Priority: | medium | ||
Version: | 7.1.0.1 rc | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=129961 https://bugs.documentfoundation.org/show_bug.cgi?id=144092 https://bugs.documentfoundation.org/show_bug.cgi?id=150557 |
||
Whiteboard: | target:7.3.0 target:7.2.3 target:7.1.7 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 139899 | ||
Attachments: |
Sample compared in MSO and LO
A modified sample without borders |
Description
Gerald Pfeifer
2021-08-25 23:15:51 UTC
Created attachment 174555 [details]
Sample compared in MSO and LO
OK, thanks for filing. Of course repro in master 7.3+.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/37a52d30bbfcf1d073779b50139c4dafa507be4b tdf#144091 svx: fix unwanted blur of shadow from table cell fill It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I think this is now fixed on master. Created attachment 175185 [details]
A modified sample without borders
The fix removed the blur from the cell fills, while MSO does apply the blur; the difference is not avoiding the blur, but taking the fill transparency into account (previous code treated any fill in object as 100% opaque thing in blurred shadow).
The attachment has one table without borders; it is visible that MSO still blurs the fills.
(In reply to Mike Kaganski from comment #4) Just a (possibly unrelated, but still) bit of parallel: it seems that blurring in shadows could (incorrectly) use something similar to what *glow effect* used, where it was a deliberate necessity to treat everything not completely transparent as 100% opaque when generating the glow. Aha, let me see how to tweak this further to address both cases. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/288eab2fbb859689d84082810afb15b2a229f12d tdf#144091 svx: fix unwanted blur of shadow from table cell fill It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/00fa364a2403dc23a786d3f91fde06e10b3a4a9a Related: tdf#144091 svx: fix interaction of transp cell fill and transp shadow It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/20883c42370e014a085533010c219aecf167bfda tdf#144091 svx: fix unwanted blur of shadow from table cell fill It will be available in 7.1.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/1f8687d2261082d1a76527c41bc1010ebcf0ddd1 Related: tdf#144091 svx: fix interaction of transp cell fill and transp shadow It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/0f99f237be9ee4135a548e255c6c8dcceba8648d Related: tdf#144091 svx: fix interaction of transp cell fill and transp shadow It will be available in 7.1.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |