Bug 143977

Summary: In “View” menus and "Tabbed" toolbars, be consistent about “hide / show”
Product: LibreOffice Reporter: j.a.swami
Component: UIAssignee: BogdanB <buzea.bogdan>
Status: RESOLVED FIXED    
Severity: enhancement CC: 79045_79045, buzea.bogdan, heiko.tietze, mentoring
Priority: lowest Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Version: 7.1.5.2 release   
Hardware: All   
OS: All   
Whiteboard: target:7.6.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 85811    

Description j.a.swami 2021-08-20 16:47:15 UTC
Description:
In the “View” menus, we have various items to be viewed or not:

    • Status bar
    • Formatting marks
    • Text boundaries

And so on. 

Tick the box, and the canvas will show the item. Untick it and the canvas hides it.

But at least two items depart from this convention. We have: 

    • Show Whitespace
    • Show Tracked Changes

To be consistent, these items should simply be:

    • Whitespace
    • Tracked Changes

And to keep the present defaults, “Whitespace” should be ticked by default, “Tracked changes” unticked.

This change will make the menus more consistent—and easier for the eye to scan. 

The same applies to toolbars. In the “Tabbed” and “Tabbed Compact” user interfaces, “Show Whitespace” should just be “Whitespace.” 


Steps to Reproduce:
1. Where available, click the "View" dropdown menu

or

1. Switch to "Tabbed" or "Tabbed Compact" interface.
2. Click view.
3. See the toolbar.

Actual Results:
Displays:

"Show Whitespace" 

and

 "Show Tracked Changes"

Expected Results:
Display:

"Whitespace"

and

"Tracked Changes"


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.1.5.2 / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Flatpak
Calc: threaded
Comment 1 Roman Kuznetsov 2021-08-22 20:36:24 UTC
I think it was made advisedly

Heiko, do you remember something related?
Comment 2 Heiko Tietze 2021-08-23 07:29:26 UTC
"Show Whitespace" was introduced for bug 124686 but without contextual label. It would be the Label of <node oor:name=".uno:ShowWhitespace" oor:op="replace"> in officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu that needs to be changed and <prop oor:name="ContextLabel" oor:type="xs:string"> needs to be added with the "Show".

It's similar to "Show Track Changes" (.uno:ShowTrackedChanges) where we have just "Show" under Edit > TC. Since the functionality is distributed over the menu I think keeping the lo0ng version makes sense.
Comment 3 Commit Notification 2023-01-09 09:44:03 UTC
Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3dbaeb2edffa7147fde02643f527c5d71465af37

tdf#143977 Consistent hide/show in Toolbars

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.