| Summary: | Disable cell style commands and sidebar when sheet is protected | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Roman Kuznetsov <79045_79045> |
| Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | ||
| Severity: | enhancement | CC: | 79045_79045, heiko.tietze |
| Priority: | medium | ||
| Version: | 7.3.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=149857 | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107332 | ||
|
Description
Roman Kuznetsov
2021-06-28 11:50:49 UTC
You cannot apply a Cell Style to protected sheets, neither per content menu > Styles nor the main menu > Styles or the sidebar via deck Styles. In all cases the messagebox shows up "Protected sheets can not be modified". In addition, it's not possible to modify the styles - otherwise you could turn red cells into green. And this fails silently. However, I don't think the way to go is to pretend it works but show a message box telling the opposite. We should rather disable the Styles commands and the sidebar deck content if the sheet is protected. Code pointer might be ScFormatShell::GetStyleState() in sc/source/ui/view/formatsh.cxx (but not sure). The patch https://gerrit.libreoffice.org/c/core/+/131665 disables all Cell Styles (no access to the complete tree, selection of cell styles disabled). Would be nice to change the tooltip in this case but no idea how to do that. Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a3cb71ac80c0c2971e97c033d212cf4e464fa8f0 Resolves tdf#143100 - Disable cell style commands when sheet is protected It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3babbc31bf4bba35924c25c5fbd59e1c314d3627 Revert "Resolves tdf#143100 - Disable cell style commands when sheet is protected" It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/9d6ae0b8d2ebb3931b3c46147e14939e7ed3f3ed Revert "Resolves tdf#143100 - Disable cell style commands when sheet is protected" It will be available in 7.5.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/bb0ed581a5624a8827ede86658872daca1754675 Revert "Resolves tdf#143100 - Disable cell style commands when sheet is protected" It will be available in 7.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |