| Summary: | FILEOPEN DOCX: Outline numbering on Heading X styles not imported well. | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Justin L <jluth> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jluth, suokunlong |
| Priority: | medium | Keywords: | filter:docx |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=106541 https://bugs.documentfoundation.org/show_bug.cgi?id=148561 |
||
| Whiteboard: | target:7.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | 141964 | ||
| Bug Blocks: | 108770, 136194 | ||
| Attachments: |
chapterNumberingTortureTest6.docx: hand-modified using Heading 4 style
chapterNumberingTortureTest6.pdf: printed from Word 2003 chapterNumberingTortureTest7.docx: a related example, adding a test for no numId specified. Test docx generated by MSO with a simple Heading 1 |
||
|
Description
Justin L
2021-04-29 07:41:02 UTC
Created attachment 171491 [details]
chapterNumberingTortureTest6.pdf: printed from Word 2003
P.S. In old Word 2003, the body-level numbering still picked up the indenting from the numbering style, but in Word 2016 it doesn't.
Created attachment 171498 [details]
chapterNumberingTortureTest7.docx: a related example, adding a test for no numId specified.
The rule seems to be:
-numId is essential. If it is missing, numbering is off (which makes sense).
-listLevel is optional. If it is missing, it means level0 (the first level).
-outlineLevel has no impact at all on listLevel or numbering.
In this document, Heading 3 (which in LO automatically has the "Outline" numId attached) should not have numbering enabled.
Generally LO handles this correctly, I'm happy to see. The only time I see a problem here is with Heading X styles.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2f9d909a01f90197c3029a446f8aac8135f53f48 tdf#76817 tdf#141966 ooxmlexport: write OutlineRule if not inherited It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. There are MANY patches in gerrit waiting for LO 7.3 to start. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3e09e0784ad7669d3e0a7655f5e604a2387b1b5d tdf#141966 writerfilter CN: fix chapter number identification It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e5b3f975144228d49c0bac71031fc7356fd252ab tdf#141966 writerfilter CN: set minimum threshold It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 175033 [details] Test docx generated by MSO with a simple Heading 1 This document opens fine with master (i.e. the numbering is "I." for heading 1), but does not work on 7.2 branch (i.e. the numbering shows "A."). I reverse bibisect to commit 3e09e0784ad7669d3e0a7655f5e604a2387b1b5d. I hope this fix also be implemented on 7.2. But as Justin has mentioned in that.commit, it is risky? And maybe we should remove the target:7.2.0 whiteboard flag here? (In reply to Kevin Suo from comment #7) > I hope this fix also be implemented on 7.2. But as Justin has mentioned in > that.commit, it is risky? Extremely risky. There is absolutely no way that I will stick my neck out and backport any of these commits to 7.2. |