Bug 141322

Summary: "Changing the attribute of all hyperlinks" applies only for Internet Links, plus need to mention Application Colors for "visited" and "unvisited" links
Product: LibreOffice Reporter: sdc.blanco
Component: DocumentationAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: olivier.hallot, rafael.palma.lima
Priority: medium    
Version: 7.1.0.3 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=134456
https://bugs.documentfoundation.org/show_bug.cgi?id=141323
https://bugs.documentfoundation.org/show_bug.cgi?id=108170
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 120200    

Description sdc.blanco 2021-03-29 11:38:00 UTC
[1]   (a) "Changing the attribute of all hyperlinks"  should specify that
           this is only for internet hyperlinks.
      (b)  maybe the heading can be improved. 
           For example:  "Formatting Internet Hyperlinks"
      (c)  mention Tools > LibreOffice > Application Colors  "visited links" and
           "unvisited links" for setting colors for other hyperlinks.

[2] refers to "Character Styles" and "visited links" and "unvisited links", but 
     (a) it should be "visited internet links" and "unvisited internet links"
     (b) make clear that Character Styles is only for Internet hyperlinks
     (c) mention Tools > LibreOffice > Application Colors  "visited links" and
         "unvisited links" for setting colors for other hyperlinks.


[1] https://help.libreoffice.org/7.2/en-US/text/shared/guide/hyperlink_edit.html

[2] https://help.libreoffice.org/7.2/en-US/text/shared/01/05020400.html
Comment 1 sdc.blanco 2021-03-29 12:15:52 UTC
I clearly do not understand the expected behavior - see bug 141323.
Therefore, consider comment 0 as a "hypothesis", which should be corrected appropriately to the expected behavior of the UI.
Comment 2 Rafael Lima 2021-04-26 22:29:28 UTC
Hi! Actually LO Writer has two styles for links:
- Internet Link
- Visited Internet Link

Both apply to all links created with the Insert > Hyperlink dialog:

https://help.libreoffice.org/7.2/en-US/text/shared/02/09070000.html?&DbPAR=WRITER&System=UNIX

IMO the section "Changing the attribute of all hyperlinks" help page is correct and works not only for internet links.

I made some tests with internet links as well as links to files and sections within files and all cases had their styles applied correctly.

I also had the correct behavior using the Format > Character dialog.

Could you please check again?
Comment 3 Rafael Lima 2021-10-07 14:08:24 UTC
I was revisiting this bug report and a few things came to mind:

1) The options under Tools > LibreOffice > Application Colors are not applicable to document styles but rather to colors used in the application itself. This is why they're not applied in the document. However, I wonder where the "visited links" and "unvisited links" colors are applied. One would assume that they would be applied to links in LO user interface such as the ones in the Extensions dialog, however they do not seem to be applied there (at least using the Kf5 VCL). So can we conclude that these colors under "Tools > LibreOffice > Application Colors" are useless and they should be removed from the dialog?

2) The colors applied to links always come from the character styles "Internet link" and "Visited internet link". However, as I mentioned before the styles are not applied only to "internet" links, but rather to any hyperlink inserted in the document (such as internal links for document targets).

In summary, I do not think we have a documentation bug at hand, but rather some improvements that need to be made to the UI and the default document template:

1) In the default template rename "Internet Link" and "Visited internet link" to "Hyperlink" and "Visited Hyperlink", respectively.

2) Remove the "visited links" and "unvisited links" colors from the Tools > LibreOffice > Application Colors dialog, unless someone can find where these colors are useful.
Comment 4 Rafael Lima 2021-10-07 14:31:34 UTC
Adding to my previous message, I found one place where the "unvisited links" color from the Tools > LibreOffice > Application Colors dialog is applied. Links created in LO Draw and Impress get the "visited links" color by default, since there are no Character styles in Impress.

However, clicking the link is not changing the color to the "visited links" color. Maybe this is a separate bug.