Summary: | FILEOPEN Cannot open .docx in writer - format openXML | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jan Chroust <jan.chroust> |
Component: | Writer | Assignee: | Aron Budea <aron.budea> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | aron.budea, jan.chroust, raal |
Priority: | medium | Keywords: | bibisected, bisected, filter:docx, regression |
Version: | 5.0.0.5 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=137357 | ||
Whiteboard: | target:7.2.0 target:7.1.2 target:7.0.5 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 104444, 104450, 140202 | ||
Attachments: |
screenshot with error when open .docx in witer - format open XML
validation .docx in open SDK Productivity Tool 2.5 generated .docx PDF of the sample, exported from Word |
Description
Jan Chroust
2021-02-03 18:45:51 UTC
Created attachment 169451 [details]
screenshot with error when open .docx in witer - format open XML
Created attachment 169452 [details]
validation .docx in open SDK Productivity Tool 2.5
Created attachment 169453 [details]
generated .docx
I can confirm with Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 40b56cd8da8c38582dc4660b486993d1b4711535 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Regression. In LO 4.4 I can open file - all 13 pages. I tried to bibisect with bibisect-44max$ under linux, but lots of crashes. Bibisect unsuccessful. The file gas in its tables: <w:tblGrid> <w:gridCol/> <w:gridCol/> </w:tblGrid> We fail to handle missing "w" attribute of w:gridCol. It should be handled as if there's no saved grid width information, while we handle it as explicit zero-width column. (Aside: then why putting it into the file? This doesn't change the fact that this is still a bug.) ... and also there are tables where no table width information (neither in grid, nor in tblW, nor in tcW) exists - we apparently don't handle that gracefully. (In reply to raal from comment #4) > Regression. In LO 4.4 I can open file - all 13 pages. I tried to bibisect > with bibisect-44max$ under linux, but lots of crashes. Bibisect unsuccessful. Bibisected the change to a reasonably complete file open to an almost empty imported document to the following range using repo bibisect_win_44: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=eed1ea797acfe69af587adbefe60316ba6ba127..78e670b3055f92740402803174d61d058effb5d7 In Linux the crashes start with the following commit (document looks reasonably fine before), which is the second to latest commit in the list above, and is a likely candidate: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2149e924cbc32c370128c5f87a4f55c50c99e6bd author Caolán McNamara <caolanm@redhat.com> 2014-11-01 20:37:30 +0000 committer Caolán McNamara <caolanm@redhat.com> 2014-11-01 21:02:15 +0000 coverity#1000600 Division or modulo by float zero Created attachment 170098 [details]
PDF of the sample, exported from Word
Aron Budea committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/67d41607ad3b97abbb939a989e491af932e985a7 tdf#140137 Don't throw exception when w:gridCol is missing "w" attr It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fixed in master, backport to 7.1 is on gerrit. Aron Budea committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/526c0a35bc6863e1f9356f237195c804ebd58feb tdf#140137 Don't throw exception when w:gridCol is missing "w" attr It will be available in 7.1.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Aron Budea committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/102ddaa04193a3303e4d3d3e2193048aad3dc16a tdf#140137 Don't throw exception when w:gridCol is missing "w" attr It will be available in 7.0.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Aron Budea committed a patch related to this issue. It has been pushed to "libreoffice-7-0-5": https://git.libreoffice.org/core/commit/31c1f9dd56184307db0743b0b4bef9510e601c1a tdf#140137 Don't throw exception when w:gridCol is missing "w" attr It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verifed Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: d47628f287f4377394c4ff488c433bfe254b6abe CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded |