Summary: | "Ignore double spaces" option in AutoCorrect might be better labeled "prevent double spaces" - and behaves differently than Help page | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | sdc.blanco |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEEDINFO --- | ||
Severity: | normal | CC: | telesto, vsfoote |
Priority: | medium | ||
Version: | 7.2.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103341 |
Description
sdc.blanco
2021-01-28 11:48:39 UTC
Tried again with a new version installed. "Ignore double spaces" might be better labelled "Prevent double spaces". If "Ignore double spaces" is enabled, and AutoCorrect > While Typing is Enabled. then: (a) if the cursor is on a space, then it is not possible to introduce additional spaces. (b) if the cursor is in a text string, then it is possible to introduce one space, but not any more. In short, with this option enabled, it is impossible to make more than one space. Tested in Writer and Calc. Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 396c2ad2daad6fe6a11703d0ae1593929834afe2 Source code also comments it as "prevent double space" https://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx?r=94306083#1312 Conclusions: 1. The documentation needs to be updated. The current description was present in its initial check-in in 2004. 2. The option was available in OOo 1.1.0 3. Maybe ask UXEval on changing Option name to "Prevent double spaces"? From: https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Common.xcs?r=35713de9#1374 <prop oor:name="RemoveDoubleSpaces" oor:type="xs:boolean" oor:nillable="false"> <!-- OldPath: AutoCorrect/Options/All --> <!-- OldLocation: Soffice.cfg --> <!-- UIHints: Tools AutoCorrect/AutoFormat Options Ignore Double Spaces --> <info> <desc>Specifies if multiple spaces should be combined into one.</desc> <label>Ignore double spaces</label> </info> <value>false</value> </prop> Was the intention to create a "removedoublespaces" function, and along the way, the vision changed to "prevent" double spaces, without a corresponding updating here in the registry (which then got copied into Help?) If there is no intention for a "remove double spaces" function, then a friendly source code cleanup would be to rename "RemoveDoubleSpaces" to "PreventDoubleSpaces" and rename the "IgnoreDoubleSpace" flag ( include/editeng/svxacorr.hxx ), which is used in ( editeng/source/misc/acorrcfg.cxx and cui/source/tabpages/autocdlg.cxx ) to something like "NoDoubleSpace" cui/inc/strings.hrc to change label of Option (In reply to sdc.blanco from comment #1) > In short, with this option enabled, it is impossible to make more than one > space. Correction: Cursor placed immediately after a character can always insert a space, even if there are multiple spaces after it. (no opinion about whether "bug" or "feature" -- just an observation -- which some might consider a "workaround" for how to add spaces (albeit, one at a time). Another observation: Can use Tab key anywhere. Hello sdc.blanco@youmail.dk, I've marked this as NEEDINFO as I'm not sure which OS you used to test. I tested this on MacOS Sonoma 14.1.2 with the ARM64 processor Apple M2 Pro Chip and I was unable to reproduce the bug with the steps you gave. I tested both on the stable build and master/daily build listed below. Version: 24.2.1.2 (AARCH64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 10; OS: macOS 14.1.2; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: 1cda27cf69054b006aa1b16cab8f56339274588b CPU threads: 10; OS: macOS 14.1.2; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded |