Summary: | Calc sheet cells keep direction despite sheet direction switch | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Eyal Rozenberg <eyalroz1> |
Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | 79045_79045, elya.govallo, erack, heiko.tietze, himajin100000, ilmari.lauhakangas, stephane.guillou |
Priority: | medium | Keywords: | needsDevAdvice |
Version: | 7.0.3.1 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=138863 https://bugs.documentfoundation.org/show_bug.cgi?id=144296 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | 138863 | ||
Bug Blocks: | 43808 |
Description
Eyal Rozenberg
2020-12-12 17:06:51 UTC
Hello! Please add your hardware, because bug doesn't repro in my. (In reply to Eleonora Govallo from comment #1) Intel Core i5-7600K. Still seeing this with: Version: 7.2.0.1 / LibreOffice Community Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_IL); UI: en-US Calc: threaded OS is Devuan GNU/Linux Chimaera. [Automated Action] NeedInfo-To-Unconfirmed Eyal, do you think cell style and visual sheet attributes are linked? I don't think so. Your report is more enhancement than really bug. And I'm not sure it can be implemented. Let's ask design team also (In reply to Roman Kuznetsov from comment #4) > Eyal, do you think cell style and visual sheet attributes are linked? I > don't think so. Direction is not just a visual attribute, it's a semantic one. Also, regardless - cell style and sheet style are linked. Once styles support any "inherit" capabilities, then the style of an object is linked to that of its superordinate object. The superordinate object of a cell is the sheet. So, it must inherit the sheet direction. > Your report is more enhancement than really bug. It's a bug, because the cell style literally says it's inheriting the superordinate object direction. Also, users expect these directions to change when they change a sheet to be RTL. They do not expect to need to also manually change the cell directions. Sheet > LTR (only enabled if tools > options > language: CTL is checked) switches the sheet direction so column A starts at right. Cells take a default style with the language defined in tools > options > language > default language for documents. If you set this to Hebrew you cell content in RTL. Don't see what we can improve here. > Sheet > LTR (only enabled if tools > options > language: CTL is checked) switches the sheet direction so column A starts at right. That's true and appropriate. > Cells take a default style with the language defined in tools > options > language > default language for documents. A style is not a language. The cell's Text Direction direction is not a cell's language. A cell's direction is independent of the default language - it is "Use superordinate object settings". > If you set this to Hebrew you cell content in RTL. You can't set a cell's text direction to "Hebrew". Also, a user should not have to set the default language for documents to Hebrew, for the Text Direction to match the sheet direction by default. > Don't see what we can improve here. I hope this comment clarifies it. [Automated Action] NeedInfo-To-Unconfirmed (In reply to Eyal Rozenberg from comment #7) > I hope this comment clarifies it. Not really. The text direction follows the superordinate object, which is defined via tools > options > language > locale. Asking to bind the text direction to the sheet direction makes not much sense to me. My take => WF. (In reply to Heiko Tietze from comment #9) > (In reply to Eyal Rozenberg from comment #7) > > I hope this comment clarifies it. > > Not really. The text direction follows the superordinate object, which is > defined via tools > options > language > locale. No, it isn't... the superordinate object of a cell is the page, or the sheet if you will. Sheet/Page direction is effected (or perhaps I should say should be effected by: 1. Toggling Sheet > Right-to-Left on the menu 2. Setting the Page text direction in the Page Style. This is just like in Writer, if your paragraph uses superordinate object direction, you can make it switch direction via Format | Page Style or by setting the text direction in the page style in effect. > Asking to bind the text direction to the sheet direction makes not much sense to me. It is actually already bound to sheet/page direction: If I edit the page style and change the direction, the cell direction changes. It just doesn't work when I do it via toggling Sheet > Right-to-Left. Eyal, how do you envisage this to be implemented (with what we currently have, if we ignore bug 138863)? Would it be that an extra page style is available in LO, called something like "Default (LTR)", which has the LTR text direction and is applied automatically to the sheet when the UI is LTR or when a sheet is switched to LTR? (In reply to Stéphane Guillou (stragu) from comment #11) > Eyal, how do you envisage this to be implemented (with what we currently > have, if we ignore bug 138863)? There is no other solution I can think of. > Would it be that an extra page style is available in LO, called something > like "Default (LTR)", which has the LTR text direction and is applied > automatically to the sheet when the UI is LTR or when a sheet is switched to > LTR? Oh no, none of that silliness. It's bad enough Writer has a bunch of nonsensical and confusing page styles (see bug 140655, bug 160682, bug 160684, bug 160686), we should really not have that here. But even regardless of nonsensical page styles: Many, if not most, RTL-language users use an LTR UI, probably the English one. We still expect cell directions to flip when changing the sheet direction. |