Summary: | Writer: multi-column page formating reset when editing page style. | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Renaud <renaudlottiaux> |
Component: | Writer | Assignee: | Justin L <jluth> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jbfaure, jluth, renaudlottiaux |
Priority: | medium | Keywords: | preBibisect |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
Column glitch test case
modified page style (custom page style 5) |
Description
Renaud
2020-11-29 11:49:45 UTC
Created attachment 167642 [details]
Column glitch test case
The file to use to produce the bug.
For me there is no bug here. When you click the Apply button you ask to apply the page style, including the column width it defines. The columns have probably been resized so that their widths no longer correspond to what is defined by the page style. I tested on a new document and the default width for a 2 columns page with 0 margins is not the column width of your page style. That said if I try to change the column widths in the page style to match what they should be, the values are lost when I reopen the page style dialog. I think your problem comes from the use of border (right) instead of margin. In the attached file, I modified the page style : - right border : 0 - right margin : 2,3 cm - size of the background image set to the page size - columns 2 (left < right), size 7,6 cm , 11,69 cm with these settings, I have a page style with stable column widths. Note: I suggest you to ask on users@fr.libreoffice.org mailing list for help to improve the layout of your document. For example, defining multiple columns when you use only one, is not a good idea. Best regards. JBF Created attachment 167660 [details]
modified page style (custom page style 5)
Thanks for your reply. I agree on the strange layout of my page, coming from difficulty I had to set a full page backgroung image with large page borders. Your tips help me to fix this. However, whatever the page layout, I think loosing the column values when I reopen the style dialog is still a bug :) There is indeed a problem here; it is a bug IMO. I don't know exactly how to reproduce this from scratch, but e.g. one interesting part to note is padding from right set on Borders tab. Also worth noting that the page style dialog behavior differs when applying, depending if the Columns tab was or wasn't opened. The reason it is resetting to equivalent widths is because the total column size is not the same as the page width size. So it resets to nActWidth, since it is much wider. nActWidth = rSize.GetSize().Width() - rLRSpace.GetLeft() - rLRSpace.GetRight() - rBox.GetSmallestDistance(); if( m_xColMgr->GetActualSize() != nActWidth) The problem is with GetSmallestDistance - which ends up being the right border padding because // The smallest distance that is not 0 will be returned. (In reply to Justin L from comment #6) > The reason it is resetting to equivalent widths is because the total column > size is not the same as the page width size. Not quite accurate. Resetting the total width doesn't break things (although it does seem like a back and forth), it is the call to ColModify( nullptr ) that resets to default. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b84bcb4fd70ae920ac2f54f70919b773fa9b2e78 tdf#138546 sw PageDialog: fix bad reset of colwidth It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |