Bug 138293

Summary:	Add "save sketches on slides on exit" option to Slide Show Settings dialog
Product:	LibreOffice	Reporter:	Maris Nartiss <maris.nartiss>
Component:	Impress	Assignee:	Devansh Varshney <varshney.devansh614>
Status:	ASSIGNED ---
Severity:	enhancement	CC:	79045_79045, georg.westbeld, heiko.tietze, mentoring, vsfoote
Priority:	medium	Keywords:	difficultyMedium, easyHack, skillCpp, topicUI
Version:	7.0.2.2 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=51928 https://bugs.documentfoundation.org/show_bug.cgi?id=129898
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:	94699, 112687
Bug Blocks:	103610, 107817

Description Maris Nartiss 2020-11-17 19:34:22 UTC

In presentation mode mouse cursor can act as a pen. Depending on presenter style, user might want to keep markings on exit or to remove them. At the moment actual behaviour of pen depends on a way how it was activated and not on a explicit setting (activated via Slide Show settings or via right click on slide). This is confusing as one has to remember to activate pen in a correct way for his preferred approach to work.

Please make this bad design to go away – just provide a separate option to keep/ignore drawings on slides at the exit from presentation.

Users failing to understand why drawings are not saved: Bug 51928
Users failing to understand why drawings are saved: Bug 122274
Here is a developer comment stating that current behaviour is not a bug but per design:
https://bugs.documentfoundation.org/show_bug.cgi?id=122274#c8

Comment 1 Roman Kuznetsov 2020-12-13 11:11:58 UTC

+1 from me

UX-team, what do you think?

Comment 2 V Stuart Foote 2020-12-13 15:20:43 UTC

+1, entering the annotation mode 'Mouse pointer as pen' is done from main menu Slide Show -> Slide Show Settings... dialog.

Otherwise during default presentation, the same 'Mouse pointer as pen' is available from context menu, but markings there are transitory. The annotation remains during the presentation--but is deleted on exiting.

Annotations made when set in advance from Slide Show Settings... persist, and user is prompted to Save them as changes when closing Impress.

Seems there should be a better way to organize this as OP requests.

Annd while looking at it we should probably tackle quality and stability issues of doing the annotations with cursor--i.e. bug 94699 and bug 112687

Comment 3 Antonello 2020-12-13 16:22:40 UTC

Hello, I am the reported of bug #112687.

Just to add that without a rewriting of the algorithm of handwriting-during-presentation, the option to save the drawing would be pretty useless, as currently instead of using the "normal" handwriting" algorithm, the in-presentation drawings are made of way too many points that make the saved presentation (if these are included with) way too large/bugged.

Comment 4 Heiko Tietze 2020-12-15 09:50:19 UTC

(In reply to V Stuart Foote from comment #2)
> +1, entering the annotation mode 'Mouse pointer as pen' is done from main
> menu Slide Show -> Slide Show Settings... dialog.

Let's do it. And handle the other topic in different issues.

Comment 5 Heiko Tietze 2020-12-16 13:24:38 UTC

(In reply to Heiko Tietze from comment #4)
> Let's do it. And handle the other topic in different issues.

Non-sense, the option exists (as setting for the slide show or per context menu, which is not available when the presenter console is active). And the annotation is stored in the document but only when enabled per slide show setting.

This means we should
a) introduce a shortcut to toggle the pen in presenter mode
b) save annotations also when the mode was enabled during the presentation

Code pointer for b) is ATTR_PRESENT_PEN set in sd/source/ui/dlg/present.cxx via m_xCbxPen while sd/source/ui/slideshow/slideshowimpl.cxx covers the context menu with mbUsePen

For a) officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu (for the help text) and slideshowimpl.cxx SlideshowImpl::keyInput() for the interaction;

I suggest to drop N/P for next/previous slide and use P for the pen

Comment 6 Regina Henschel 2023-08-12 15:39:37 UTC

*** Bug 57602 has been marked as a duplicate of this bug. ***

Comment 7 Devansh Varshney 2024-03-23 11:46:41 UTC

I have made some changes to the mentioned and the related files.

https://gerrit.libreoffice.org/c/core/+/165144

Bit, a little stuck with constructor definition.